fix(chart): move app=componentName label out of csi-node matchLabels #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niladrih
requested review from
tiagolobocastro,
avishnu,
sinhaashish,
Abhinandan-Purkait and
r1jt
The label `app: openebs-zfs-node` was missing on the csi-node components. However, adding it to the selector labels section breaks upgrade from previous versions. This need not live in matchLabels, and could simply live in componentLabels Signed-off-by: Niladri Halder <[email protected]>
|
Should our tests have caught this, are we still lacking in the testing? |
Abhinandan-Purkait
approved these changes
Dec 20, 2024
sinhaashish
approved these changes
Jan 6, 2025
There is a gap in testing for upgrade scenarios. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The label
app: openebs-zfs-nodewas missing on the csi-node components. However, adding it to the selector labels section breaks upgrade from previous versions.This need not live in matchLabels, and could simply live in componentLabels
Fixes #593