-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zfs): timer stop when checkVolCreation exit #600
Conversation
@rfyiamcool Please sign your commit. Can you please explain the change and the current issue on the PR description? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #600 +/- ##
========================================
Coverage 95.99% 95.99%
========================================
Files 1 1
Lines 574 574
========================================
Hits 551 551
Misses 19 19
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ab7343f
to
c193520
Compare
done 😁 |
I still see the DCO failing. You should check the steps here https://github.com/openebs/zfs-localpv/pull/600/checks?check_run_id=32630888366 |
c193520
to
75bce7e
Compare
Sorry, it's okay now. 😁 |
@rfyiamcool Thanks, can you please rebase, once that is done, we can do the merging. |
Signed-off-by: rfyiamcool <[email protected]>
75bce7e
to
611b755
Compare
done |
Pull Request template
Why is this PR required? What issue does it fix?:
when func is end, we need to stop timer.
What this PR does?:
when func is end, we need to stop timer.
Does this PR require any upgrade changes?:
If the changes in this PR are manually verified, list down the scenarios covered::
Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>
PLEASE REMOVE BELOW INFORMATION BEFORE SUBMITTING
The PR title message must follow convention:
<type>(<scope>): <subject>
.Where:
type
is defining if release will be triggering after merging submitted changes, details in CONTRIBUTING.md.Most common types are:
feat
- for new features, not a new feature for build scriptfix
- for bug fixes or improvements, not a fix for build scriptchore
- changes not related to production codedocs
- changes related to documentationstyle
- formatting, missing semi colons, linting fix etc; no significant production code changestest
- adding missing tests, refactoring tests; no production code changerefactor
- refactoring production code, eg. renaming a variable or function name, there should not be any significant production code changesscope
is a single word that best describes where the changes fit.Most common scopes are like:
localpv
,jiva
,cstor
)provisioning
,backup
,restore
,exporter
)api
,webhook
,cast
,upgrade
)tests
,bdd
)version
,build
,log
,travis
)subject
is a single line brief description of the changes made in the pull request.