-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deploy): indent for imagePullSecrets #596
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #596 +/- ##
===========================================
- Coverage 96.37% 95.99% -0.38%
===========================================
Files 1 1
Lines 496 574 +78
===========================================
+ Hits 478 551 +73
- Misses 14 19 +5
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you please a signature to your commit?
https://github.com/openebs/zfs-localpv/blob/develop/CONTRIBUTING.md#sign-your-work
@chris199512 can you please sign your commit as @tiagolobocastro suggested, then we can merge it |
Signed-off-by: chris199512 <[email protected]>
Signed-off-by: chris199512 <[email protected]>
* feat(compression): allow zstd-fast algorithm Signed-off-by: Abhinandan Purkait <[email protected]> * test: add new entry for zstd-fast compression Signed-off-by: Abhinandan Purkait <[email protected]> * chore: simplify the regex Signed-off-by: Abhinandan Purkait <[email protected]> --------- Signed-off-by: Abhinandan Purkait <[email protected]> Signed-off-by: chris199512 <[email protected]>
Signed-off-by: Alexandre Buisine <[email protected]> Signed-off-by: chris199512 <[email protected]>
* Velero doesn't start the Restic Pods anymore. * Also update the AWS-Plugin. Signed-off-by: Rasmus Thomsen <[email protected]> Signed-off-by: chris199512 <[email protected]>
Why is this PR required? What issue does it fix?:
When we were pulling the image from a private repo, we noticed that the synax is wrong for zfs-node and zfs-controller. The indent must be 8 and not 2.
What this PR does?:
change indent
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
N/A
Any additional information for your reviewer? :
N/A
Checklist:
Fixes
PR Title follows the convention of ():
Has the change log section been updated?
Commit has unit tests
Commit has integration tests
(Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
(Optional) If documentation changes are required, which issue on https://github.com/openebs/website is used to track