-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reservation): while expanding, with refquota setting #595
fix(reservation): while expanding, with refquota setting #595
Conversation
Signed-off-by: Alexandre Buisine <[email protected]>
59df1ae
to
20fda15
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #595 +/- ##
========================================
Coverage 96.37% 96.37%
========================================
Files 1 1
Lines 496 496
========================================
Hits 478 478
Misses 14 14
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @abuisine LGTM. Would you mind adding a test for the same? Or we can take that up with a separate issue/pr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should we also update one of the resize tests to check the reservation is updated?
@tiagolobocastro Can you please re-approve it. Seems like the two simultaneous operations removed your approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @abuisine Are anymore changes left from your side or can we merge this?
Except unit tests which could be done in a different MR, nope
Le mer. 16 oct. 2024 à 12:19, Abhinandan Purkait ***@***.***>
a écrit :
… ***@***.**** approved this pull request.
LGTM. @abuisine <https://github.com/abuisine> Are anymore changes left
from your side or can we merge this?
—
Reply to this email directly, view it on GitHub
<#595 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIHLGNXPZ4LHDZSJX2C5WLZ3Y4UDAVCNFSM6AAAAABPWKJVN2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZRHE2DKMJTGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@abuisine Thanks, merging this now. |
Signed-off-by: Alexandre Buisine <[email protected]> Signed-off-by: chris199512 <[email protected]>
Hi there ! Any chance to see this released soon ? |
@abuisine Yes, we would be releasing in couple of weeks. cc @avishnu @tiagolobocastro |
Why is this PR required? What issue does it fix?:
Fixes #568
What this PR does?:
Apply reservation while expanding volumes/filesystems
Does this PR require any upgrade changes?:
No
If the changes in this PR are manually verified, list down the scenarios covered::
N/A
Any additional information for your reviewer? :
Continuation of #589
Checklist:
<type>(<scope>): <subject>