Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(charts): correct default chart values #506

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

jnels124
Copy link
Contributor

@jnels124 jnels124 commented Feb 20, 2024

Pull Request template

Please, go through these steps before you submit a PR.

Why is this PR required? What issue does it fix?:
Gets rid of warning message when deploying helm chart

What this PR does?:
Corrects the default values for the helm chart. The usage in the chart expects these values to be dictionaries, not arrays.

Does this PR require any upgrade changes?:
no

If the changes in this PR are manually verified, list down the scenarios covered::
deployed chart locally with changes to ensure warning message went away and verified successful deployment

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes Default values are of the wrong type #505
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

@hrudaya21 hrudaya21 merged commit 6888ac7 into openebs:develop Feb 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default values are of the wrong type
3 participants