refactor(charts): simplify CRD helm chart values

Signed-off-by: Niladri Halder <[email protected]>
openebs · Mar 19, 2024 · ae884d7 · ae884d7
1 parent d468819
commit ae884d7
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 55 deletions.
diff --git a/deploy/helm/charts/Chart.yaml b/deploy/helm/charts/Chart.yaml
@@ -17,7 +17,6 @@ sources:
 dependencies:
   - name: crds
     version: "2.5.0"
-    condition: crds.enabled
 maintainers:
   - name: xUnholy
     email: [email protected]

diff --git a/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot-class.yaml b/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot-class.yaml
@@ -1,4 +1,4 @@
-{{- if and .Values.volumeSnapshots.enabled .Values.volumeSnapshots.snapshotClassesEnabled -}}
+{{- if .Values.csi.volumeSnapshots.enabled -}}
 {{- $crdName := "volumesnapshotclasses.snapshot.storage.k8s.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 apiVersion: apiextensions.k8s.io/v1

diff --git a/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot-content.yaml b/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot-content.yaml
@@ -1,4 +1,4 @@
-{{- if and .Values.volumeSnapshots.enabled .Values.volumeSnapshots.snapshotContentsEnabled -}}
+{{- if .Values.csi.volumeSnapshots.enabled -}}
 {{- $crdName := "volumesnapshotcontents.snapshot.storage.k8s.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 apiVersion: apiextensions.k8s.io/v1

diff --git a/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot.yaml b/deploy/helm/charts/charts/crds/templates/csi-volume-snapshot.yaml
@@ -1,4 +1,4 @@
-{{- if and .Values.volumeSnapshots.enabled .Values.volumeSnapshots.snapshotsEnabled -}}
+{{- if .Values.csi.volumeSnapshots.enabled -}}
 {{- $crdName := "volumesnapshots.snapshot.storage.k8s.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 apiVersion: apiextensions.k8s.io/v1

diff --git a/deploy/helm/charts/charts/crds/templates/zfsbackup.yaml b/deploy/helm/charts/charts/crds/templates/zfsbackup.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.zfsBackups.enabled -}}
+{{- if .Values.zfsLocalPv.enabled -}}
 {{- $crdName := "zfsbackups.zfs.openebs.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 ##############################################

diff --git a/deploy/helm/charts/charts/crds/templates/zfsnode.yaml b/deploy/helm/charts/charts/crds/templates/zfsnode.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.zfsNodes.enabled -}}
+{{- if .Values.zfsLocalPv.enabled -}}
 {{- $crdName := "zfsnodes.zfs.openebs.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 ##############################################

diff --git a/deploy/helm/charts/charts/crds/templates/zfsrestore.yaml b/deploy/helm/charts/charts/crds/templates/zfsrestore.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.zfsRestores.enabled -}}
+{{- if .Values.zfsLocalPv.enabled -}}
 {{- $crdName := "zfsrestores.zfs.openebs.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 ##############################################

diff --git a/deploy/helm/charts/charts/crds/templates/zfssnapshot.yaml b/deploy/helm/charts/charts/crds/templates/zfssnapshot.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.zfsSnapshots.enabled -}}
+{{- if .Values.zfsLocalPv.enabled -}}
 {{- $crdName := "zfssnapshots.zfs.openebs.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 ##############################################

diff --git a/deploy/helm/charts/charts/crds/templates/zfsvolume.yaml b/deploy/helm/charts/charts/crds/templates/zfsvolume.yaml
@@ -1,4 +1,4 @@
-{{- if .Values.zfsVolumes.enabled -}}
+{{- if .Values.zfsLocalPv.enabled -}}
 {{- $crdName := "zfsvolumes.zfs.openebs.io" -}}
 {{- if (include "crdIsAbsent" (list $crdName)) -}}
 ##############################################

diff --git a/deploy/helm/charts/charts/crds/values.yaml b/deploy/helm/charts/charts/crds/values.yaml
@@ -1,29 +1,8 @@
-zfsBackups:
-  # -- Install ZfsBackup CRD
+zfsLocalPv:
+  # Install zfs-localpv CRDs
   enabled: true
 
-zfsNodes:
-  # -- Install ZfsNode CRD
-  enabled: true
-
-zfsRestores:
-  # -- Install ZfsRestore CRD
-  enabled: true
-
-zfsSnapshots:
-  # -- Install ZfsSnapshot CRD
-  enabled: true
-
-zfsVolumes:
-  # -- Install ZfsVolume CRD
-  enabled: true
-
-volumeSnapshots:
-  # -- Install Volume Snapshot CRDs
-  enabled: true
-  # -- Install volumesnapshots.snapshot.storage.k8s.io CRD
-  snapshotsEnabled: true
-  # -- Install volumesnapshotclasses.snapshot.storage.k8s.io CRD
-  snapshotClassesEnabled: true
-  # -- Install volumesnapshotcontents.snapshot.storage.k8s.io CRD
-  snapshotContentsEnabled: true
+csi:
+  volumeSnapshots:
+    # Install Volume Snapshot CRDs
+    enabled: true
diff --git a/deploy/helm/charts/values.yaml b/deploy/helm/charts/values.yaml
@@ -174,23 +174,10 @@ zfs:
   bin: zfs
 
 crds:
-  # Enable/Disable all CRDs
-  enabled: true
-  zfsBackups:
-    # -- Install ZfsBackup CRD
-    enabled: true
-  zfsNodes:
-    # -- Install ZfsNode CRD
-    enabled: true
-  zfsRestores:
-    # -- Install ZfsRestore CRD
-    enabled: true
-  zfsSnapshots:
-    # -- Install ZfsSnapshot CRD
-    enabled: true
-  zfsVolumes:
-    # -- Install ZfsVolume CRD
-    enabled: true
-  volumeSnapshots:
-    # -- Install Volume Snapshot CRDs
+  zfsLocalPv:
+    # Install zfs-localpv CRDs
     enabled: true
+  csi:
+    volumeSnapshots:
+      # Install Volume Snapshot CRDs
+      enabled: true