This repository has been archived by the owner on Feb 15, 2022. It is now read-only.
Add support of STS assume role. #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlvenable
reviewed
Jul 22, 2021
| credentialsProvider = StsAssumeRoleCredentialsProvider.builder() | ||
| .stsClient(StsClient.create()) | ||
| .refreshRequest(AssumeRoleRequest.builder() | ||
| .roleSessionName("Elasticsearch-Sink-" + UUID.randomUUID() |
There was a problem hiding this comment.
I mentioned this in the other review.
Should we include the pipeline name here?
e.g.
roleSessionName(pipelineName + "-" + UUID.randomUUID().toString())
It could be obtained from pluginSetting.getPipelineName() in the static factory.
There was a problem hiding this comment.
Missed the comment. Fixed it. in the next push.
dlvenable
approved these changes
Jul 22, 2021
dinujoh
approved these changes
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #731:
Description of changes:
Add support of STS assume role option.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.