Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JDK Quickstarters #973

Merged
merged 10 commits into from
Jan 31, 2024
Merged

Update JDK Quickstarters #973

merged 10 commits into from
Jan 31, 2024

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Dec 5, 2023 •
edited
Loading

Related to #966

JDK agent

  • Build successfull with java 11, 17 and 21
  • Switch between java versions works

SpringBoot

  • Provision successfull
  • Build successfull
  • Example app working

Spock

  • Provision successfull
  • Build successfull
  • Example app working

@BraisVQ BraisVQ linked an issue Dec 5, 2023 that may be closed by this pull request
Maintenance of jdk agent, Java and Spock-Geb quickstarter #966
Closed
@BraisVQ BraisVQ changed the title Feature/update java qs Update JDK Quickstarters Dec 5, 2023
@BraisVQ BraisVQ marked this pull request as ready for review December 5, 2023 17:12
@renedupont
Copy link
Member

The build failed

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Dec 7, 2023

The build failed

The mirror from terrarium jdk failed last build. Now it is working

renedupont
renedupont previously approved these changes Dec 18, 2023
View reviewed changes
docs/modules/jenkins-agents/pages/jdk.adoc Outdated Show resolved Hide resolved
@oalyman
Copy link
Contributor

oalyman commented Jan 30, 2024

LGTM.

I think it would be nice to create a jdk 21 only agent as well. For teams that did the switch and would not need to have a build agent with 3 JVMs installed.

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Jan 30, 2024

LGTM.

I think it would be nice to create a jdk 21 only agent as well. For teams that did the switch and would not need to have a build agent with 3 JVMs installed.

If we want to use SonarQube we still need java 11. Even if we update SonarQube to the version 9.9 LTS the scanner will still needs java 17 so it is not possible to have an agent with only 1 JDK regrettably

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Jan 31, 2024

Checked internaly with maintainers of Spock and they are ok with this update

@BraisVQ BraisVQ merged commit 6af1164 into master Jan 31, 2024
19 checks passed
@BraisVQ BraisVQ deleted the feature/update_java_qs branch January 31, 2024 12:57
BraisVQ added a commit that referenced this pull request Feb 19, 2024
@BraisVQ
Update JDK Quickstarters (#973)
11dee81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renedupont renedupont renedupont left review comments

@stitakis stitakis stitakis left review comments

@oalyman oalyman oalyman approved these changes

@metmajer metmajer Awaiting requested review from metmajer metmajer is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maintenance of jdk agent, Java and Spock-Geb quickstarter
4 participants
@BraisVQ @renedupont @oalyman @stitakis