Provide secret scanning for local setup #963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There we go, as dicussed in our meeting. This:
Anything that I'm missing? |
serverhorror
requested review from
metmajer,
michaelsauter,
nichtraunzer,
tbugfinder and
bljubisic
as code owners
serverhorror
requested review from
sklingel,
gerardcl,
sino92,
oalyman,
buegelbeatz,
henrjk,
stitakis,
renedupont and
clemensutschig
as code owners
renedupont
reviewed
Oct 25, 2023
cschweikert
reviewed
Oct 26, 2023
docs/modules/quickstarters/partials/secret-scanning-with-gitleaks.adoc
Outdated
Show resolved
Hide resolved
henrjk
reviewed
Oct 26, 2023
stitakis
reviewed
Oct 26, 2023
…aks.adoc Co-authored-by: Christian Schweikert <[email protected]>
Co-authored-by: Christian Schweikert <[email protected]>
cschweikert
approved these changes
Nov 3, 2023
henrjk
approved these changes
Nov 6, 2023
stitakis
approved these changes
Nov 6, 2023
|
Hello, @michaelsauter, @oalyman, @metmajer, @nichtraunzer, @bljubisic, @buegelbeatz, @tbugfinder, @sino92, @clemensutschig, @sklingel Your reviews are missing. Can this be merged? Are there any tests that need to run for this to be accepted? |
michaelsauter
approved these changes
Nov 9, 2023
renedupont
approved these changes
Nov 9, 2023
I am not, I will never merge my own PRs. Apart from that: I don't even have the technical permissions. Whoever merges, merges :) |
oalyman
approved these changes
Nov 14, 2023
|
@metmajer, @nichtraunzer, @tbugfinder, @bljubisic, @sklingel, @sino92, @buegelbeatz, @clemensutschig Ping! Your approvals are still missing, or you can merge if you are happy with the existing approvals. |
bljubisic
approved these changes
Nov 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description here ...
Closes #...
Fixes #...
Tasks:
docs/modules/...directory<quickstarter>/testdatadirectory