Cypress evidence improvements #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
October 2, 2024 08:08
It also adds some metadata to the taken screenshot
…also upload them to nexus
…ready pushed in e2e-cypress
cschweikert
reviewed
Oct 9, 2024
cschweikert
previously approved these changes
Oct 9, 2024
|
Is there something missing to get this PR merged? |
Hi, I already approved it 😉 LGTM from a code perspective. The golden sample tests should not be affected by the code changes, but I guess you tested this anyways. Then feel free to merge. |
|
@matzehecht I put the zip, stashing and archiving for video inside an conditional, because it fails the pipeline if you do not generate it Aside of this, it is good already |
cschweikert
approved these changes
Oct 10, 2024
BraisVQ
approved these changes
Oct 10, 2024
|
@cschweikert @matzehecht @BraisVQ storing potentially large .zip files on a rather limited disk mount is totally discouraged and must be stored in Nexus instead. I have asked for this to be addressed in #1079. Please consider for next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the test evidences for the e2e-cypress quickstarter by:
Closes #1042
Tasks:
docs/modules/...directory<quickstarter>/testdatadirectory