Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1059 fix for npm config auth on jenkins agents #1060

Merged

Conversation

gerardcl
Copy link
Member

@gerardcl gerardcl commented Sep 15, 2024

Fixes #1059

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@gerardcl gerardcl self-assigned this Sep 15, 2024
tbugfinder
tbugfinder previously approved these changes Sep 15, 2024
Copy link
Contributor

@tbugfinder tbugfinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gerardcl gerardcl force-pushed the fix/1059-npm-config-set-auth-repo-url-without-scheme branch from da2683c to 1e9bfd5 Compare September 16, 2024 06:48
@gerardcl gerardcl requested a review from tbugfinder September 16, 2024 06:48
Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node agent build and usage in pipeline works properly

@gerardcl gerardcl merged commit 3f34cea into master Sep 17, 2024
23 checks passed
@gerardcl gerardcl deleted the fix/1059-npm-config-set-auth-repo-url-without-scheme branch September 17, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node npm related quickstarter agents do not handle auth for private nexus repositories
3 participants