-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jdk and scala quickstarters / agents #1050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests for the jdk and scala agents fail because base image does not have java 17 yet, so until the PR for the update of Jenkins on ods-core gets merged this PR cannot be merged either, for the time being, I will continue testing |
BraisVQ
changed the title
Update jdk quickstarters and agent
Update jdk and scala quickstarters / agents
Aug 29, 2024
BraisVQ
requested review from
metmajer,
oalyman,
stitakis and
renedupont
as code owners
September 2, 2024 07:07
renedupont
reviewed
Sep 2, 2024
stitakis
reviewed
Sep 2, 2024
stitakis
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@braisvq1996 thanks a lot for updating java!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the java update on the agent base the default version is now jdk 17 instead of 11 so this is a breaching change.
We will still maintain java 11 on this agent for retrocompatibility
Closes #1032, #1037
Depends on opendevstack/ods-core#1299
Tasks:
docs/modules/...
directory