Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdk and scala quickstarters / agents #1050

Merged
merged 14 commits into from
Sep 3, 2024

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Aug 29, 2024

With the java update on the agent base the default version is now jdk 17 instead of 11 so this is a breaching change.
We will still maintain java 11 on this agent for retrocompatibility

Closes #1032, #1037
Depends on opendevstack/ods-core#1299

Tasks:

  • Updated documentation in docs/modules/... directory
  • Update and build jdk agent
  • Update and test java Quickstarter with new agent version (test switch between java versions)
  • Updte and build scala agent (only update it to match the changes in the agent base)
  • Update and test scala Quickstarter (only update it to match the changes in the agent base)

@BraisVQ BraisVQ linked an issue Aug 29, 2024 that may be closed by this pull request
@BraisVQ
Copy link
Contributor Author

BraisVQ commented Aug 29, 2024

The tests for the jdk and scala agents fail because base image does not have java 17 yet, so until the PR for the update of Jenkins on ods-core gets merged this PR cannot be merged either, for the time being, I will continue testing

@BraisVQ BraisVQ linked an issue Aug 29, 2024 that may be closed by this pull request
@BraisVQ BraisVQ changed the title Update jdk quickstarters and agent Update jdk and scala quickstarters / agents Aug 29, 2024
@BraisVQ BraisVQ added the maintenance only for maintenance of components label Aug 30, 2024
@BraisVQ BraisVQ marked this pull request as ready for review September 2, 2024 07:07
Copy link
Member

@stitakis stitakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@braisvq1996 thanks a lot for updating java!

@BraisVQ BraisVQ merged commit 82f7e4d into master Sep 3, 2024
23 checks passed
@BraisVQ BraisVQ deleted the feature/update-java-quickstarter branch September 3, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance only for maintenance of components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jenkins agent jdk - build failure Maintenance of jdk agent, Java and Spock-Geb quickstarter
3 participants