Docker plain helm chart

[segfault16]

Add helm chart for docker plain

Refers to #1013

Tasks:

• Updated documentation in docs/modules/... directory
• Ran tests in <quickstarter>/testdata directory
• Shared library adaptions

[BraisVQ]

The base image has been changed to nginxinc/nginx-unprivileged because the alpine one did not work properly with the container probes

[gerardcl]

The base image has been changed to nginxinc/nginx-unprivileged because the alpine one did not work properly with the container probes

and this also now does match with the values.yaml image section, perfect!

[BraisVQ]

Provision, build, and release pipelines have been tested and works out of the box with the latest commits.

[BraisVQ]

Just in case we forget, this file should be removed before the PR is merged

[segfault16]

also helm lint

[segfault16]

Still needed?

[renedupont]

service.enabled is never used

[faust2199]

Fixed with commit fe5fa7f

[faust2199]

Having a very strict values.schema.json is probably not going to provide good experience when using helmValues defined from the Jenkinsfile. According to https://helm.sh/docs/topics/charts/ , "the schema is applied to the final .Values object, and not just to the values.yaml file."

Let's say we have the following in the Jenkinsfile:
odsComponentStageRolloutOpenShiftDeployment(context, [ 'selector': "app.kubernetes.io/name=${context.componentId}", 'helmEnvBasedValuesFiles': ['values.env.yaml'], 'helmValues': [ 'foo': 'bar' ] ]

When the above runs on Jenkins, ods-jenkins-shared-library will add two arguments on the command line:
--set foo=bar --set global.foo=bar

Then it will be aborted because additionalProperties are not allowed in both places. Is the user really expected to add two entries in values.schema.json to fix this?

I suggest that we remove the whole values.schema.json file. If the result of rendering is bad, helm upgrade is going to fail and rollback anyway.

[renedupont]

Having a very strict values.schema.json is probably not going to provide good experience when using helmValues defined from the Jenkinsfile. According to https://helm.sh/docs/topics/charts/ , "the schema is applied to the final .Values object, and not just to the values.yaml file."

Let's say we have the following in the Jenkinsfile: odsComponentStageRolloutOpenShiftDeployment(context, [ 'selector': "app.kubernetes.io/name=${context.componentId}", 'helmEnvBasedValuesFiles': ['values.env.yaml'], 'helmValues': [ 'foo': 'bar' ] ]

When the above runs on Jenkins, ods-jenkins-shared-library will add two arguments on the command line: --set foo=bar --set global.foo=bar

Then it will be aborted because additionalProperties are not allowed in both places. Is the user really expected to add two entries in values.schema.json to fix this?

I suggest that we remove the whole values.schema.json file. If the result of rendering is bad, helm upgrade is going to fail and rollback anyway.

I partially agree, I think there is a middle way though. In the values.schema.json we could set "additionalProperties": false to true in the relevant parts. That way we validate everything that is set in that file and everything else will not be considered and not lead to failing the helm validation.