-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress - added custom reporter and updated dependecies versions #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunatelly, this PR is missing a description and a link to an issue. Therefore it is hard to understand, what this is all about, especially what value the custom reporter is adding.
Co-authored-by: Christian Schweikert <[email protected]>
Co-authored-by: Christian Schweikert <[email protected]>
Co-authored-by: Christian Schweikert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As some versions have been updated, the documentation should also be updated
updated tree in documentation
fixed record script (was not passing correctly the record flag thus not working)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😊
BTW Do we still need #1042?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This change adds a custom reporter to the Cypress quickstarter. The reporter, based on Mocha JUnit, now embeds logs into the XML report under the system-out field. I also added hooks to save logs to files after each test, which the reporter uses. These changes fix the issue where logs were not being embedded in the XML report as intended by the
printTestEvidence
function.Tasks:
docs/modules/...
directory<quickstarter>/testdata
directory