Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress - added custom reporter and updated dependecies versions #1034

Merged
merged 10 commits into from
Aug 28, 2024

Conversation

roicarrera
Copy link
Contributor

@roicarrera roicarrera commented Jul 29, 2024

This change adds a custom reporter to the Cypress quickstarter. The reporter, based on Mocha JUnit, now embeds logs into the XML report under the system-out field. I also added hooks to save logs to files after each test, which the reporter uses. These changes fix the issue where logs were not being embedded in the XML report as intended by the printTestEvidence function.

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@roicarrera roicarrera requested a review from cschweikert as a code owner July 29, 2024 07:23
Copy link
Member

@cschweikert cschweikert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunatelly, this PR is missing a description and a link to an issue. Therefore it is hard to understand, what this is all about, especially what value the custom reporter is adding.

e2e-cypress/files/support/e2e.ts Outdated Show resolved Hide resolved
e2e-cypress/files/support/e2e.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
e2e-cypress/files/cypress.config.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As some versions have been updated, the documentation should also be updated

e2e-cypress/Jenkinsfile.template Show resolved Hide resolved
@BraisVQ BraisVQ added maintenance only for maintenance of components enhancement New feature or request labels Aug 20, 2024
@BraisVQ BraisVQ changed the title added custom reporter and updated dependecies versions Cypress - added custom reporter and updated dependecies versions Aug 22, 2024
fixed record script (was not passing correctly the record flag thus not working)
Copy link
Member

@cschweikert cschweikert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😊

BTW Do we still need #1042?

Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BraisVQ BraisVQ merged commit b1c5784 into opendevstack:master Aug 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance only for maintenance of components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants