Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance of jdk agent, Java and Spock-Geb quickstarter #1032

Closed
BraisVQ opened this issue Jul 26, 2024 · 7 comments · Fixed by #1050
Closed

Maintenance of jdk agent, Java and Spock-Geb quickstarter #1032

BraisVQ opened this issue Jul 26, 2024 · 7 comments · Fixed by #1050
Labels
enhancement New feature or request maintenance only for maintenance of components

Comments

@BraisVQ
Copy link
Contributor

BraisVQ commented Jul 26, 2024

JDK Agent

Package Current Version Sugested version Location
Java 11, 17 and 21 N/A Dockerfile

Java-SpringBoot Quickstarter

Package Current Version Sugested version Location
jdk base image ubi9/openjdk-21 N/A Dockerfile
Gradle gradle-8.4-bin gradle-8.9-bin gradle-wrapper.properties
SpringBoot 3.2.0 3.3.2 Jenkinsfile

Spock-Geb Quickstarter

Package Current Version Sugested version Location
Gradle gradle-8.4-bin gradle-8.9-bin gradle-wrapper.properties
spockVersion 2.3-groovy-4.0 N/A build.gradle
Junit 5.10.1 5.10.1 build.gradle
Geb 7.0 N/A build.gradle
Selenium 4.15.0 4.23.0 build.gradle
htmlunit 4.13.0 N/A build.gradle
unirest 3.14.5 N/A build.gradle

The Spock-Geb Quickstarter maintenance can be part of #1025

@garcanam @bassagan

@BraisVQ BraisVQ added enhancement New feature or request maintenance only for maintenance of components labels Jul 26, 2024
@renedupont
Copy link
Member

renedupont commented Aug 20, 2024

@braisvq1996 Is there a reason to keep Java 11 in the JDK agent? The support for it ended last year September. Is there anything still that depends on that? I think you updated the CNES report to a version that does not require Java 11 anymore, right?

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Aug 20, 2024

The current SonarQube version (9.9) still requires java 11.
From Sonarqube 10.x, the scanner can be triggered using java 17

My intention is for this to be the last revision to have java 11 because it will also end its support in Jenkins soon -> opendevstack/ods-core#1295

@stitakis
Copy link
Member

stitakis commented Aug 20, 2024

For the sake of forsting innovation and using the latest java features I would also include the latest LTS java version and also latest intermediate version which is today version 22, but we can opt for version 23 once is released in september.

@renedupont
Copy link
Member

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Aug 22, 2024

With the changes on the next Jenkins update, java 11 gets removed so only jdk agent will maintain java 11 for now

@renedupont
Copy link
Member

I'm confused I think. Wouldn't that mean that the sonar scanner would not work anymore for any jenkins agent other than JDK agent because according to your comment above it requires Java 11?

@BraisVQ
Copy link
Contributor Author

BraisVQ commented Aug 23, 2024

My bad @renedupont, what I mean to say is that the current binary for the SonarQube scanner needs java 11 but I intend to update that so we can use java 17. This change will apply to all agents, no only jdk.

I still need to test this to be sure it works properly, but if everything goes well java 17 will be the default java version from now on and we will maintain java 11 on jdk agent for retrocompatibility.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance only for maintenance of components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants