Merge branch 'feature/remove-crowd-soap' of https://github.com/opende…

…vstack/ods-provisioning-app into feature/remove-crowd-soap
opendevstack · Sep 29, 2023 · 45ec79c · 45ec79c
2 parents c13a57f + bd329ed
commit 45ec79c
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 2 deletions.
diff --git a/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java b/src/main/java/org/opendevstack/provision/authentication/filter/SSOAuthProcessingFilter.java
@@ -89,7 +89,6 @@ boolean storeTokenIfCrowdMethodUsed(
       HttpServletRequest request, HttpServletResponse response, Authentication authResult) {
     if (authResult instanceof CrowdSSOAuthenticationToken && authResult.getCredentials() != null) {
       try {
-        // TODO check if this suffices
         super.storeTokenIfCrowd(request, response, authResult);
         return true;
       } catch (Exception e) {

diff --git a/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java b/src/test/java/org/opendevstack/provision/authentication/TestAuthentication.java
@@ -32,7 +32,6 @@ public String getName() {
   @Override
   public Collection<GrantedAuthority> getAuthorities() {
     if (authorities != null) {
-      // TODO check if we need to return a new list of auths
       return authorities;
     } else {
       List<GrantedAuthority> auths = new ArrayList<>();