fix bug replacing agent images #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NR4l3rt0
force-pushed
the
hotfix/replacing-agent-image-panic
branch
from
4f7f1c1 to
1191a64
Compare
…hat method and create different unit tests suites
NR4l3rt0
force-pushed
the
hotfix/replacing-agent-image-panic
branch
from
1191a64 to
7839db3
Compare
|
More refactorization in the last force commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to help making changes to Jenkinsfiles.
Context
While working in the ODS migration, we found out that this program, although helpful, panicked for various reasons. One of them can be seen here: Converter tool panics when "imageStreamTag" does not follow strictly the pattern #5
Change
In an attempt for doing the program more resilient, the method 'replaceAgentImages' has been changed and some unit tests were also added.
It would be great if somebody could merge this or could give me some feedback to improve the quality of the commit, since we will try to build upon this program and automate other processes.
Note: I've closed the previous pull request (#7) because I think that the history is cleaner and more meaningful this way, and I've changed a variable in the anonymous function too.
Best regards,
thanks for your time