Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DSC Blog to refer v1 api #199

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

VaishnaviHire
Copy link
Member

Description

How Has This Been Tested?

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

enabled: false
distributedworkloads:
enabled: true
managementState: Removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
managementState: Removed
managementState: Managed

enabled: true
managementState: Removed
codeflare:
managementState: Managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
managementState: Managed
managementState: Removed

codeflare:
managementState: Managed
ray:
managementState: Managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
managementState: Managed
managementState: Removed

modelmeshserving:
enabled: false
managementState: Removed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
managementState: Removed
managementState: Managed

- **managementState**: Defines value for a component's status. It is set to one of the following values:
- "Managed" : the operator is actively managing the component and trying to keep it active. It will only upgrade the component if it is safe to do so
- "Removed" : the operator is actively managing the component and will not install it, or if it is installed, the operator will try to remove it
- **devFlags**: Fields under this struct if set, lets user run the operator in [Dev Mode](https://github.com/opendatahub-io/opendatahub-operator/wiki/3.-Using-Operator-in-Dev-Mode).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **devFlags**: Fields under this struct if set, lets user run the operator in [Dev Mode](https://github.com/opendatahub-io/opendatahub-operator/wiki/3.-Using-Operator-in-Dev-Mode).
- **devFlags**: Fields under this struct if set, let user run the operator in [Dev Mode](https://github.com/opendatahub-io/opendatahub-operator/wiki/3.-Using-Operator-in-Dev-Mode).

@VaishnaviHire VaishnaviHire merged commit 05b9cce into opendatahub-io:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants