Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name, resource label, tolerations and Node selector fields - Unlimited size string #3672

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+21 −9
Open

Name, resource label, tolerations and Node selector fields - Unlimited size string #3672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions frontend/src/pages/hardwareProfiles/nodeResource/NodeResourceTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { Td, Tr } from '@patternfly/react-table';
import { ActionList, ActionListItem, Button } from '@patternfly/react-core';
import { ActionList, ActionListItem, Button, Truncate } from '@patternfly/react-core';
import { MinusCircleIcon, PencilAltIcon } from '@patternfly/react-icons';
import { Identifier } from '~/types';

Expand All @@ -18,8 +18,12 @@ const NodeResourceTableRow: React.FC<NodeResourceTableRowProps> = ({
showActions,
}) => (
<Tr>
<Td dataLabel="Resource label">{identifier.displayName}</Td>
<Td dataLabel="Resource identifier">{identifier.identifier}</Td>
<Td dataLabel="Resource label">
<Truncate content={identifier.displayName} />
</Td>
<Td dataLabel="Resource identifier">
<Truncate content={identifier.identifier} />
</Td>
<Td dataLabel="Resource type">{identifier.resourceType ?? 'Other'}</Td>
<Td dataLabel="Default">{identifier.defaultCount}</Td>
<Td dataLabel="Minimum allowed">{identifier.minCount}</Td>
Expand Down
10 changes: 7 additions & 3 deletions frontend/src/pages/hardwareProfiles/nodeSelector/NodeSelectorTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { Td, Tr } from '@patternfly/react-table';
import { ActionList, ActionListItem, Button } from '@patternfly/react-core';
import { ActionList, ActionListItem, Button, Truncate } from '@patternfly/react-core';
import { MinusCircleIcon, PencilAltIcon } from '@patternfly/react-icons';
import { NodeSelector } from '~/types';

Expand All @@ -18,8 +18,12 @@ const NodeSelectorTableRow: React.FC<NodeSelectorTableRowProps> = ({
onDelete,
}) => (
<Tr>
<Td dataLabel="Key">{nodeSelector.key}</Td>
<Td dataLabel="Value">{nodeSelector.value}</Td>
<Td dataLabel="Key">
<Truncate content={nodeSelector.key} />
</Td>
<Td dataLabel="Value">
<Truncate content={nodeSelector.value} />
</Td>
{showActions && (
<Td isActionCell modifier="nowrap" style={{ textAlign: 'right' }}>
<ActionList isIconList>
Expand Down
10 changes: 7 additions & 3 deletions frontend/src/pages/hardwareProfiles/toleration/TolerationTableRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import { Td, Tr } from '@patternfly/react-table';
import { ActionList, ActionListItem, Button } from '@patternfly/react-core';
import { ActionList, ActionListItem, Button, Truncate } from '@patternfly/react-core';
import { MinusCircleIcon, PencilAltIcon } from '@patternfly/react-icons';
import { Toleration } from '~/types';

Expand All @@ -19,8 +19,12 @@ const TolerationTableRow: React.FC<TolerationTableRowProps> = ({
}) => (
<Tr>
<Td dataLabel="Operator">{toleration.operator ?? '-'}</Td>
<Td dataLabel="Key">{toleration.key}</Td>
<Td dataLabel="Value">{toleration.value ?? '-'}</Td>
<Td dataLabel="Key">
<Truncate content={toleration.key} />
</Td>
<Td dataLabel="Value">
<Truncate content={toleration.value ?? '-'} />
</Td>
<Td dataLabel="Effect">{toleration.effect ?? '-'}</Td>
<Td dataLabel="Toleration seconds">
{toleration.tolerationSeconds === undefined
Expand Down
Loading