-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Show the GPU requests and limits in workbench table #3654
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
WIP: need to add same for the hardware profiles |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3654 +/- ##
==========================================
- Coverage 84.26% 84.25% -0.01%
==========================================
Files 1432 1434 +2
Lines 33489 33514 +25
Branches 9284 9297 +13
==========================================
+ Hits 28218 28237 +19
- Misses 5271 5277 +6
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Thanks @dpanshug for doing this. Overall, it looks great. |
RHOAIENG-16749
Description
How Has This Been Tested?
Create a workbench and connect it to accelerators.
Test Impact
Added unit tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main
@xianli123