-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds required to environment variables #3653
Adds required to environment variables #3653
Conversation
lgtm, thanks @ashley-o0o! |
frontend/src/pages/projects/screens/spawner/environmentVariables/EnvTypeSelectField.tsx
Outdated
Show resolved
Hide resolved
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
77112be
to
0aaef33
Compare
New changes are detected. LGTM label has been removed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3653 +/- ##
==========================================
- Coverage 85.75% 84.26% -1.49%
==========================================
Files 1419 1450 +31
Lines 32684 33769 +1085
Branches 9191 9355 +164
==========================================
+ Hits 28027 28455 +428
- Misses 4657 5314 +657
... and 208 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3bfa9b4
into
opendatahub-io:main
Closes: RHOAIENG-1201
Description
Previously, when creating a workbench, if a user wanted to add an environment variable, a selection is required to complete the creation. There was no indication that this field was required. This PR adds a required star to the drop down if the user chooses to add the variable.
How Has This Been Tested?
Tested locally
Screenshots
Environment Variables field:
Before:
After:
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main