Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds required to environment variables #3653

Conversation

ashley-o0o
Copy link
Contributor

@ashley-o0o ashley-o0o commented Jan 16, 2025

Closes: RHOAIENG-1201

Description

Previously, when creating a workbench, if a user wanted to add an environment variable, a selection is required to complete the creation. There was no indication that this field was required. This PR adds a required star to the drop down if the user chooses to add the variable.

How Has This Been Tested?

Tested locally

  • Navigate to your data science projects, and choose one to create a workbench for.
  • In the create workbench page, scroll down to environment variables. It should be an optional field. But when you click to add variables, a title of "Variable type * " will now show.

Screenshots

Environment Variables field:
Screenshot 2025-01-16 at 3 35 54 PM

Before:
Screenshot 2025-01-16 at 3 36 25 PM

After:
Screenshot 2025-01-16 at 3 36 02 PM

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from Gkrumbach07 and ppadti January 16, 2025 20:43
@ashley-o0o
Copy link
Contributor Author

@kywalker-rh

@kywalker-rh
Copy link

lgtm, thanks @ashley-o0o!

@emilys314
Copy link
Contributor

i tested the pr image on my cluster and it looks good

/lgtm

image

Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashley-o0o ashley-o0o force-pushed the 1201/empty-environment-variable branch from 77112be to 0aaef33 Compare January 23, 2025 13:29
@openshift-ci openshift-ci bot removed the lgtm label Jan 23, 2025
Copy link
Contributor

openshift-ci bot commented Jan 23, 2025

New changes are detected. LGTM label has been removed.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (95d2b64) to head (0aaef33).
Report is 23 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3653      +/-   ##
==========================================
- Coverage   85.75%   84.26%   -1.49%     
==========================================
  Files        1419     1450      +31     
  Lines       32684    33769    +1085     
  Branches     9191     9355     +164     
==========================================
+ Hits        28027    28455     +428     
- Misses       4657     5314     +657     
Files with missing lines Coverage Δ
...pawner/environmentVariables/EnvTypeSelectField.tsx 100.00% <100.00%> (ø)

... and 208 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d2b64...0aaef33. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit 3bfa9b4 into opendatahub-io:main Jan 23, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants