Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add create/edit/duplicate hardware profile page #3604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Dec 20, 2024

JIRA: RHOAIENG-16255

Description

Added the page to create/edit/duplicate hardware profile, which allows you to add/edit/remove node selectors and tolerations. The work for the identifiers(node resources) is implemented in #3565 so this PR doesn't include that part.

On create:
Screenshot 2024-12-20 at 2 47 25 PM

On update:
Screenshot 2024-12-20 at 2 48 00 PM
Screenshot 2024-12-20 at 2 48 08 PM

On duplicate:
All the other fields will get duplicated except the name description fields
Screenshot 2024-12-20 at 4 09 08 PM

Node selector modal:
Screenshot 2024-12-20 at 2 48 34 PM
Screenshot 2024-12-20 at 2 48 45 PM

Toleration modal:
Screenshot 2024-12-20 at 2 49 05 PM
Screenshot 2024-12-20 at 2 49 18 PM

Added last modified annotation:
Screenshot 2024-12-20 at 2 49 52 PM

How Has This Been Tested?

  1. Create a hardware profile
  2. Fill in data like name, descriptions, node selectors and tolerations
  3. Click create
  4. Edit that hardware profile
  5. Make sure everything is pre-filled correctly when editing
  6. Try to edit/remove the node selectors table and tolerations table
  7. Update the hardware profile
  8. Expand to make sure the update takes effect

Test Impact

Added cypress tests for the create/edit page

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lucferbux for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@DaoDaoNoCode
Copy link
Member Author

@vconzola Could you check the screenshots? Thanks!

@DaoDaoNoCode DaoDaoNoCode changed the title Add create/edit hardware profile page Add create/edit/duplicate hardware profile page Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 96.90722% with 9 lines in your changes missing coverage. Please review.

Project coverage is 85.25%. Comparing base (ca3be32) to head (b61a5ce).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...areProfiles/manage/ManageHardwareProfileFooter.tsx 82.85% 6 Missing ⚠️
...ages/hardwareProfiles/HardwareProfilesTableRow.tsx 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3604      +/-   ##
==========================================
+ Coverage   85.15%   85.25%   +0.09%     
==========================================
  Files        1395     1407      +12     
  Lines       32041    32305     +264     
  Branches     8979     9053      +74     
==========================================
+ Hits        27284    27541     +257     
- Misses       4757     4764       +7     
Files with missing lines Coverage Δ
frontend/src/api/k8s/hardwareProfiles.ts 100.00% <100.00%> (+11.53%) ⬆️
...nd/src/pages/hardwareProfiles/HardwareProfiles.tsx 100.00% <100.00%> (+12.50%) ⬆️
.../pages/hardwareProfiles/HardwareProfilesRoutes.tsx 100.00% <ø> (ø)
...pages/hardwareProfiles/HardwareProfilesToolbar.tsx 100.00% <100.00%> (ø)
frontend/src/pages/hardwareProfiles/const.ts 100.00% <100.00%> (ø)
.../hardwareProfiles/manage/ManageHardwareProfile.tsx 100.00% <100.00%> (ø)
...reProfiles/manage/ManageHardwareProfileWrapper.tsx 100.00% <100.00%> (ø)
...dwareProfiles/manage/ManageNodeSelectorSection.tsx 100.00% <100.00%> (ø)
...ardwareProfiles/manage/ManageTolerationSection.tsx 100.00% <100.00%> (ø)
...rontend/src/pages/hardwareProfiles/manage/types.ts 100.00% <100.00%> (ø)
... and 10 more

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca3be32...b61a5ce. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant