Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update pipeline task topo #3601

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Gkrumbach07
Copy link
Member

Description

Testing different pipelines topology visualizations for ux

How Has This Been Tested?

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Dec 19, 2024
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Gkrumbach07
Copy link
Member Author

/hold

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from gkrumbach07. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/hold This PR is hold for some reason label Dec 19, 2024
@Gkrumbach07
Copy link
Member Author

/test ci/prow/images

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

@Gkrumbach07: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images
/test odh-dashboard-pr-image-mirror

Use /test all to run all jobs.

In response to this:

/test ci/prow/images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Gkrumbach07
Copy link
Member Author

/test images
/test odh-dashboard-pr-image-mirror

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (14b1c4d) to head (f6597e8).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3601      +/-   ##
==========================================
- Coverage   85.16%   85.12%   -0.04%     
==========================================
  Files        1393     1395       +2     
  Lines       31939    32039     +100     
  Branches     8955     8974      +19     
==========================================
+ Hits        27200    27274      +74     
- Misses       4739     4765      +26     
Files with missing lines Coverage Δ
...pts/pipelines/topology/usePipelineTaskTopology.tsx 97.97% <100.00%> (+0.10%) ⬆️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b1c4d...f6597e8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason do-not-merge/work-in-progress This PR is in WIP state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant