Disabling the 'Deploy model' button if NIM is disabled #3600

olavtar · 2024-12-19T20:18:57Z

https://issues.redhat.com/browse/NVPE-66
https://issues.redhat.com/browse/NVPE-34

Description

If NIM is disabled, previously deployed projects are prevented from re-deploying a NIM model by disabling the 'Deploy model' button on various screens.

How Has This Been Tested?

Tested locally and verified various scenarios:

Removed the Account CR and ensured that if it’s a NIM-enabled project, the 'Deploy model' button is disabled.
Confirmed that for a KServe project, the 'Deploy model' button remains enabled.
Verified that if the Account CR status is true, the 'Deploy model' button is enabled."

Test Impact

Cypress tests were modified to accommodate.

Request review criteria:

Self checklist (all need to be checked):

The developer has manually tested the changes and verified that the changes work
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

Included any necessary screenshots or gifs if it was a UI change.
Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

The developer has tested their solution on a cluster by using the image produced by the PR to main

Signed-off-by: Olga Lavtar <[email protected]>

openshift-ci · 2024-12-19T20:19:03Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2024-12-19T20:19:08Z

Hi @olavtar. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Olga Lavtar <[email protected]>

codecov · 2024-12-19T22:16:22Z

Codecov Report

Attention: Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.09%. Comparing base (14b1c4d) to head (49c3de4).
Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
...src/concepts/nimServing/NIMAvailabilityContext.tsx	90.90%	1 Missing ⚠️
...s/modelServing/screens/global/ServeModelButton.tsx	75.00%	1 Missing ⚠️
...eens/projects/ModelServingPlatformButtonAction.tsx	90.90%	1 Missing ⚠️
...modelServing/screens/projects/useIsNIMAvailable.ts	91.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3600      +/-   ##
==========================================
- Coverage   85.16%   85.09%   -0.07%     
==========================================
  Files        1393     1396       +3     
  Lines       31939    32067     +128     
  Branches     8955     8985      +30     
==========================================
+ Hits        27200    27289      +89     
- Misses       4739     4778      +39

Files with missing lines	Coverage Δ
frontend/src/app/App.tsx	`90.00% <ø> (ø)`
...end/src/pages/modelServing/ModelServingContext.tsx	`67.64% <ø> (ø)`
...erving/screens/global/InferenceServiceTableRow.tsx	`100.00% <100.00%> (ø)`
...g/screens/projects/EmptySingleModelServingCard.tsx	`100.00% <ø> (ø)`
...lServing/screens/projects/ModelServingPlatform.tsx	`99.11% <100.00%> (ø)`
...c/pages/modelServing/useServingPlatformStatuses.ts	`100.00% <100.00%> (ø)`
...ns/detail/overview/serverModels/AddModelFooter.tsx	`82.00% <ø> (ø)`
...il/overview/serverModels/PlatformSelectSection.tsx	`100.00% <100.00%> (ø)`
...src/concepts/nimServing/NIMAvailabilityContext.tsx	`90.90% <90.90%> (ø)`
...s/modelServing/screens/global/ServeModelButton.tsx	`93.33% <75.00%> (-1.91%)`	⬇️
... and 2 more

... and 20 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b1c4d...49c3de4. Read the comment docs.

emilys314 · 2024-12-20T19:18:41Z

/ok-to-test

emilys314 · 2024-12-20T19:23:00Z

frontend/src/pages/modelServing/screens/projects/useIsNIMAvailable.ts

  const isNIMModelServingAvailable = useIsAreaAvailable(SupportedArea.NIM_MODEL).status;

-  useEffect(() => {
-    const checkNIMServingRuntime = async () => {
-      const isNIMRuntimeAvailable = await isNIMServingRuntimeTemplateAvailable(dashboardNamespace);
-      setIsNIMAvailable(isNIMModelServingAvailable && isNIMRuntimeAvailable);
-    };
+  const fetchNIMAvailability = React.useCallback(async () => {
+    const components = await fetchComponents(false);


Could you make the fetchNIMAvailability return early with false if isNIMModelServingAvailable is false? This way it will avoid the following API calls when we already know nim is not available

…delServingAvailable is false Signed-off-by: Olga Lavtar <[email protected]>

olavtar added 2 commits December 19, 2024 12:01

fix: block nim re-deploy in existing projects

ee45a4c

Signed-off-by: Olga Lavtar <[email protected]>

fix: block nim re-deploy in existing projects

55a9d5d

Signed-off-by: Olga Lavtar <[email protected]>

openshift-ci bot requested review from mturley and ppadti December 19, 2024 20:19

openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Dec 19, 2024

fix: fix cypress tests

ab3d856

Signed-off-by: Olga Lavtar <[email protected]>

openshift-ci bot added ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. and removed needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI labels Dec 20, 2024

emilys314 reviewed Dec 20, 2024

View reviewed changes

fix: make the fetchNIMAvailability return early with false if isNIMMo…

49c3de4

…delServingAvailable is false Signed-off-by: Olga Lavtar <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disabling the 'Deploy model' button if NIM is disabled #3600

Disabling the 'Deploy model' button if NIM is disabled #3600

olavtar commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

codecov bot commented Dec 19, 2024 •

edited

Loading

emilys314 commented Dec 20, 2024

emilys314 Dec 20, 2024

olavtar Dec 20, 2024

Disabling the 'Deploy model' button if NIM is disabled #3600

Are you sure you want to change the base?

Disabling the 'Deploy model' button if NIM is disabled #3600

Conversation

olavtar commented Dec 19, 2024

Description

How Has This Been Tested?

Test Impact

Request review criteria:

openshift-ci bot commented Dec 19, 2024

openshift-ci bot commented Dec 19, 2024

codecov bot commented Dec 19, 2024 • edited Loading

Codecov Report

emilys314 commented Dec 20, 2024

emilys314 Dec 20, 2024

Choose a reason for hiding this comment

olavtar Dec 20, 2024

Choose a reason for hiding this comment

codecov bot commented Dec 19, 2024 •

edited

Loading