fix return type when creating dashboard config #3598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/RHOAIENG-15388
Description
Fixes error
Cannot read properties of undefined (reading 'notebookController')
The
resourceUtils.ts#createDashboardCR
function returned an array instead of the dashboard config itself, therefore when attempting to readspec.notebookController
from the config, it would fail sincespec
isundefined
on the array. At the same time, also returned theblankDashboardCR
in case creation were to fail.This points to a bigger issue where our tsconfig needs to be made strict.
How Has This Been Tested?
Test Impact
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main