Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visual issues on Enabled/Explore tiles #3594

Merged

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Dec 19, 2024

Closes RHOAIENG-16896

Description

Fixes visuals for tiles when disabled. Updates the colors for the actions and labels so there is better contrast in dark mode. Fix alignment of Labels on Explore page tiles.

How Has This Been Tested?

  • Navigate to Applications -> Enabled

  • View in both light and dark mode

  • Verify the visuals

  • Navigate to Applications -> Explore

  • View in both light and dark mode

  • Verify the visuals

Test Impact

No impact on automated tests, purely a visual change

Screen shots

image

image

image

image

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • Included any necessary screenshots or gifs if it was a UI change.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.17%. Comparing base (14b1c4d) to head (a2317b9).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/OdhExploreCard.tsx 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
+ Coverage   85.16%   85.17%   +0.01%     
==========================================
  Files        1393     1393              
  Lines       31939    31942       +3     
  Branches     8955     8959       +4     
==========================================
+ Hits        27200    27206       +6     
+ Misses       4739     4736       -3     
Files with missing lines Coverage Δ
frontend/src/components/OdhAppCard.tsx 63.93% <100.00%> (+1.86%) ⬆️
frontend/src/components/OdhExploreCard.tsx 88.00% <57.14%> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14b1c4d...a2317b9. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 changed the title Fix visual isses on Enabled/Explore tiles Fix visual issues on Enabled/Explore tiles Dec 19, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca3be32 into opendatahub-io:main Dec 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants