Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in proper handling of spaces and quotes in ISVC parsing #3592

Merged

Add in proper handling of spaces and quotes in ISVC parsing

42b88b2
Select commit
Loading
Failed to load commit list.
Merged

Add in proper handling of spaces and quotes in ISVC parsing #3592

Add in proper handling of spaces and quotes in ISVC parsing
42b88b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 0s

85.18% (+0.01%) compared to 2ee880d

View this Pull Request on Codecov

85.18% (+0.01%) compared to 2ee880d

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.18%. Comparing base (2ee880d) to head (42b88b2).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/api/k8s/utils.ts 81.81% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3592      +/-   ##
==========================================
+ Coverage   85.16%   85.18%   +0.01%     
==========================================
  Files        1392     1392              
  Lines       31856    31868      +12     
  Branches     8925     8927       +2     
==========================================
+ Hits        27130    27146      +16     
+ Misses       4726     4722       -4     
Files with missing lines Coverage Δ
frontend/src/api/k8s/inferenceServices.ts 96.70% <100.00%> (+0.03%) ⬆️
frontend/src/api/k8s/utils.ts 94.28% <81.81%> (-5.72%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee880d...42b88b2. Read the comment docs.