Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress e2e Maintenance - PF6/Test Enhancements/General Maintenance #3591

Merged

Conversation

antowaddle
Copy link
Contributor

@antowaddle antowaddle commented Dec 18, 2024

https://issues.redhat.com/browse/RHOAIENG-17124

Description

Make additional fixes relating to PF6/Newer RHOAI builds (required as builds were down for a number of days).
Including:

  • Additional URL exclusions linked to https://issues.redhat.com/browse/RHOAIENG-9235
  • Fixed Workbenches tests to use s2i-minimal-notebook
  • Added verbose output for clusterStorage test which is currently failing due to an issue
  • Added steps for storageClasses test to enhance readability
  • Enhanced clusterSettings test to use correct logic following a discussion with Andrew
  • Created new logic for clusterAdminSettings to align with a bug fix https://issues.redhat.com/browse/RHOAIENG-7610

How Has This Been Tested?

  • An oc login should be performed in the cluster before running the test
  • test-variables.yml should be configured properly
  • Export the path to the test-variables.yml: $ export CY_TEST_CONFIG=<path_to>/test-variables.yml
  • Tests executed against 2.17 on a RHOAI Cluster locally and via Jenkins. Note, 3 tests are failing due to known bugs.

Jenkins - RHOI 2.17
cypress-tests/71/
image

Test Impact

  • None - this is a test

How to run

After exporting the test-variables.yml we have 2 different ways:

Using the UI
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress open . This will open the Cypress UI where you can run all the tests.

Headless
Go to odh-dashboard/frontend/src/tests/cypress and run the command npx cypress run --spec "cypress/tests/e2e/" --browser chrome

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

antowaddle and others added 30 commits November 20, 2024 17:07
increase card timeout and delete active wait
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Dec 18, 2024
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.12%. Comparing base (075914a) to head (f6036ea).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3591   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files        1395     1395           
  Lines       32034    32034           
  Branches     8973     8973           
=======================================
+ Hits        27268    27270    +2     
+ Misses       4766     4764    -2     

see 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075914a...f6036ea. Read the comment docs.

@antowaddle antowaddle changed the title Cypress rhoaieng 17124 Cypress e2e Maintenance - PF6/Test Enhancements Dec 19, 2024
@antowaddle antowaddle changed the title Cypress e2e Maintenance - PF6/Test Enhancements Cypress e2e Maintenance - PF6/Test Enhancements/General Maintenance Dec 19, 2024
@antowaddle antowaddle marked this pull request as ready for review December 19, 2024 16:43
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Dec 19, 2024
@FedeAlonso FedeAlonso self-requested a review December 20, 2024 11:07
@FedeAlonso
Copy link
Contributor

Test results in latest RHOAI 2.17:
image

@FedeAlonso
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Dec 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f9ac99e into opendatahub-io:main Dec 20, 2024
6 checks passed
@antowaddle antowaddle deleted the cypress-RHOAIENG-17124 branch December 20, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants