Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow private/public route selection in KServe, when authorino is not enabled #3583

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Dec 17, 2024

Closes: RHOAIENG-10060

Description

This PR aims to allow private/public route selection in KServe, when authorino is not enabled.

Screen.Recording.2024-12-17.at.1.33.12.PM.mov
Screenshot 2024-12-16 at 4 10 14 PM

How Has This Been Tested?

In KServe, now we allow private/public route selection even when the authorino is not enabled.
when the model route checkbox is checked, we will show warning alert.

Test Impact

Added cypress test.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@ppadti
Copy link
Contributor Author

ppadti commented Dec 17, 2024

@vconzola could you please take a look at the screen recording/screenshot?

@ppadti ppadti requested review from mturley and lucferbux December 17, 2024 08:29
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.19%. Comparing base (1896f34) to head (aa3dac9).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3583      +/-   ##
==========================================
- Coverage   85.19%   85.19%   -0.01%     
==========================================
  Files        1382     1382              
  Lines       31572    31575       +3     
  Branches     8824     8827       +3     
==========================================
+ Hits        26897    26899       +2     
- Misses       4675     4676       +1     
Files with missing lines Coverage Δ
.../ServingRuntimeModal/AuthServingRuntimeSection.tsx 94.11% <100.00%> (+1.01%) ⬆️
...screens/projects/kServeModal/ManageKServeModal.tsx 94.00% <ø> (-0.08%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1896f34...aa3dac9. Read the comment docs.

@acrago
Copy link

acrago commented Dec 17, 2024

@ppadti Vince sent this to me to review because I was the designer on this task. It looks good to me 👍

Copy link
Contributor

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested on a cluster that didn't have Authorino installed and saw the checkbox with the warning alert when checked
Screenshot 2024-12-17 at 11 53 30 PM

Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @ppadti

Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, manaswinidas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 4260e3e into opendatahub-io:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants