-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow private/public route selection in KServe, when authorino is not enabled #3583
Allow private/public route selection in KServe, when authorino is not enabled #3583
Conversation
@vconzola could you please take a look at the screen recording/screenshot? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3583 +/- ##
==========================================
- Coverage 85.19% 85.19% -0.01%
==========================================
Files 1382 1382
Lines 31572 31575 +3
Branches 8824 8827 +3
==========================================
+ Hits 26897 26899 +2
- Misses 4675 4676 +1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
@ppadti Vince sent this to me to review because I was the designer on this task. It looks good to me 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @ppadti
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, manaswinidas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-10060
Description
This PR aims to allow private/public route selection in KServe, when authorino is not enabled.
Screen.Recording.2024-12-17.at.1.33.12.PM.mov
How Has This Been Tested?
In KServe, now we allow private/public route selection even when the authorino is not enabled.
when the model route checkbox is checked, we will show warning alert.
Test Impact
Added cypress test.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main