Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: e2e Cypress migration from ODS-2206 #3580

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Test: e2e Cypress migration from ODS-2206 #3580

wants to merge 23 commits into from

Conversation

FedeAlonso
Copy link
Contributor

@FedeAlonso FedeAlonso commented Dec 16, 2024 •
edited
Loading

https://issues.redhat.com/browse/RHOAIENG-16476

Description

Cypress Smoke test from ODS-CI "ODS-2206"
Title: Verify User Can Create, Run and Delete A DS Pipeline From DS Project Details Page Using Custom Pip Mirror
This test Run an Iris DSP, and then deletes the DSP version and the DSP. All just by using the UI.
It has also the particularity that the PIP server (or mirror) is configured by env variables, so it can run in a disconnected environment.

How Has This Been Tested?

Locally against a live cluster.
Command: $ npx cypress run --spec "**/createRunDeletePipelineCustomPipMirror.cy.ts" --browser chrome
image

Test Impact

Addition of a new e2e Cypress test

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Dec 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@FedeAlonso FedeAlonso added the do-not-merge/hold This PR is hold for some reason label Dec 18, 2024
@FedeAlonso FedeAlonso marked this pull request as ready for review December 18, 2024 10:34
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Dec 18, 2024
@openshift-ci openshift-ci bot requested review from dpanshug and lucferbux December 18, 2024 10:34
@FedeAlonso FedeAlonso changed the title Test/cypress ods2206 pipelines Test: e2e Cypress migration from ODS-2206 Dec 18, 2024
@FedeAlonso FedeAlonso removed the do-not-merge/hold This PR is hold for some reason label Dec 18, 2024
@FedeAlonso FedeAlonso requested a review from ConorOM1 December 18, 2024 15:08
manosnoam
manosnoam reviewed Dec 18, 2024
View reviewed changes
Copy link
Contributor

@manosnoam manosnoam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from manosnoam. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@FedeAlonso FedeAlonso requested a review from manosnoam December 18, 2024 18:53
@manosnoam manosnoam added the lgtm label Dec 19, 2024
@openshift-ci openshift-ci bot removed the lgtm label Dec 19, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 19, 2024

New changes are detected. LGTM label has been removed.

@FedeAlonso
Copy link
Contributor Author

Tested with thhe latest changes:
image

@FedeAlonso
Copy link
Contributor Author

Tested with latest changes:
image

antowaddle
antowaddle reviewed Dec 20, 2024
View reviewed changes
Copy link
Contributor

@antowaddle antowaddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FedeAlonso Can you also please check this test against the latest ODH Nightly build? The test also currently takes 4 minutes to execute, is there any way that time can be improved? Or is there any type of splitting that can be done?

frontend/src/__tests__/cypress/cypress/pages/components/table.ts
@@ -17,7 +17,7 @@ export class TableRow extends Contextual<HTMLTableRowElement> {
}

findKebabAction(name: string): Cypress.Chainable<JQuery<HTMLElement>> {
return this.find().findKebabAction(name);
return this.find().findKebabAction(name).should('exist').and('be.visible');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check please if this is breaking the Mock Tests?
https://github.com/opendatahub-io/odh-dashboard/actions/runs/12427145849/job/34696500427?pr=3580

.../cypress/cypress/tests/e2e/dataSciencePipelines/createRunDeletePipelineCustomPipMirror.cy.ts Show resolved Hide resolved
frontend/src/__tests__/cypress/test-variables.yml.example Show resolved Hide resolved
@FedeAlonso
Copy link
Contributor Author

@FedeAlonso Can you also please check this test against the latest ODH Nightly build? The test also currently takes 4 minutes to execute, is there any way that time can be improved? Or is there any type of splitting that can be done?

This test takes 4 minutes because it's a quite complete one. Also, running a pipeline always takes time, and in this case we need to have a more complex one, as it's used also for disconnected testing.

@FedeAlonso
Copy link
Contributor Author

image
Test results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antowaddle antowaddle antowaddle left review comments

@christianvogt christianvogt Awaiting requested review from christianvogt

@dpanshug dpanshug Awaiting requested review from dpanshug

@lucferbux lucferbux Awaiting requested review from lucferbux

@ConorOM1 ConorOM1 Awaiting requested review from ConorOM1

@manosnoam manosnoam Awaiting requested review from manosnoam

Assignees

@manosnoam manosnoam

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FedeAlonso @manosnoam @antowaddle