Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-1154]: Apply modal to alert user error #3512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Nov 22, 2024

Towards https://issues.redhat.com/browse/RHOAIENG-1154.

Description

Before:
Screenshot 2024-12-19 at 5 43 39 PM

After:
Screenshot 2024-12-18 at 5 13 52 PM

How Has This Been Tested?

Run application.cy.ts to simulate 403 status code and verify the modal is rendered.

Test Impact

Added new test to application.cy.ts.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@jenny-s51 jenny-s51 removed the request for review from dpanshug November 22, 2024 16:41
@jenny-s51 jenny-s51 marked this pull request as draft November 22, 2024 16:41
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Nov 22, 2024
@jenny-s51 jenny-s51 marked this pull request as ready for review November 26, 2024 15:10
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Nov 26, 2024
@emilys314
Copy link
Contributor

emilys314 commented Nov 26, 2024

Would there be a way to detect specifically that the user's session timed out to show the new modal? I feel like it may be slightly misleading because it looks like the code is a catch all, but the message is specific for session expiration? Unless that was the idea, it also doesn't seem that straightfoward to figure out a expired session

@christianvogt
Copy link
Contributor

I agree, we should look to identify the exact error response that comes from an expired session to show this modal otherwise we show the old error or update it with some other text if it's not related to expired session.

@xianli123
Copy link

Thanks @jenny-s51. The implementation looks good to me.
As for the description in the modal, it's based on the context of RHOAIENG-1154. I agree with @emilys314 @christianvogt. It would be better to identify the exact errors, and then we can update the description in the modal. If you have any concrete idea, please let me know and I can provide new design if needed.

Copy link
Contributor

openshift-ci bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your feedback here @emilys314 @christianvogt @xianli123 - after investigating with @christianvogt we identified that a 403 status code indicates an expired session.

I've updated the implementation to render the modal when that status code is received, and added a corresponding Cypress test.

@jenny-s51 jenny-s51 force-pushed the RHOAIENG-1154 branch 2 times, most recently from 7048471 to d26db87 Compare December 20, 2024 14:14
check for 403 status code

add cypress test

update test title

format

format

format

remove it.only

fix relative import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants