-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add category option to create connection type #3141
Add category option to create connection type #3141
Conversation
Skipping CI for Draft Pull Request. |
fc8c646
to
680d6fc
Compare
frontend/src/pages/connectionTypes/manage/ManageConnectionTypePage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/connectionTypes.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/connectionTypes/createConnectionType.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/connectionTypes/createConnectionType.cy.ts
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3141 +/- ##
==========================================
+ Coverage 85.20% 85.24% +0.04%
==========================================
Files 1244 1246 +2
Lines 27117 27223 +106
Branches 7152 7197 +45
==========================================
+ Hits 23104 23207 +103
- Misses 4013 4016 +3
... and 17 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
680d6fc
to
9884360
Compare
I just tested the image on my cluster, everything seems to be working pretty good |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-11536
Description
Create a new category option on the create connection type page. This allows users to pick from predetermined categories, or create their own.
How Has This Been Tested?
Tested locally
Test Impact
Cypress tests are being created. Still in progress.
Screenshots
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main