Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add category option to create connection type #3141

Conversation

ashley-o0o
Copy link
Contributor

Closes: RHOAIENG-11536

Description

Create a new category option on the create connection type page. This allows users to pick from predetermined categories, or create their own.

How Has This Been Tested?

Tested locally

Test Impact

Cypress tests are being created. Still in progress.

Screenshots

Screenshot 2024-08-28 at 3 17 24 PM Screenshot 2024-08-28 at 3 17 35 PM Screenshot 2024-08-28 at 3 17 53 PM Screenshot 2024-08-28 at 3 17 59 PM

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 29, 2024
Copy link
Contributor

openshift-ci bot commented Aug 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ashley-o0o ashley-o0o force-pushed the 11536/add-connection-type-category-option branch from fc8c646 to 680d6fc Compare August 30, 2024 16:30
@ashley-o0o ashley-o0o marked this pull request as ready for review August 30, 2024 16:30
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 91.22807% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.24%. Comparing base (3174a74) to head (9884360).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
frontend/src/components/MultiSelection.tsx 90.47% 4 Missing ⚠️
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3141      +/-   ##
==========================================
+ Coverage   85.20%   85.24%   +0.04%     
==========================================
  Files        1244     1246       +2     
  Lines       27117    27223     +106     
  Branches     7152     7197      +45     
==========================================
+ Hits        23104    23207     +103     
- Misses       4013     4016       +3     
Files with missing lines Coverage Δ
frontend/src/pages/connectionTypes/columns.ts 44.44% <ø> (ø)
frontend/src/pages/connectionTypes/const.ts 100.00% <100.00%> (ø)
...onnectionTypes/manage/ManageConnectionTypePage.tsx 90.38% <100.00%> (+1.49%) ⬆️
.../pages/connectionTypes/ConnectionTypesTableRow.tsx 62.22% <80.00%> (+2.22%) ⬆️
frontend/src/components/MultiSelection.tsx 77.14% <90.47%> (+3.61%) ⬆️

... and 17 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3174a74...9884360. Read the comment docs.

@ashley-o0o ashley-o0o force-pushed the 11536/add-connection-type-category-option branch from 680d6fc to 9884360 Compare August 30, 2024 17:57
@emilys314
Copy link
Contributor

I just tested the image on my cluster, everything seems to be working pretty good

@emilys314
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented Aug 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f447d45 into opendatahub-io:main Aug 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants