Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for select components causing scroll container to jump #3134

Closed

Conversation

jeff-phillips-18
Copy link
Contributor

@jeff-phillips-18 jeff-phillips-18 commented Aug 28, 2024

Closes RHOAIENG-11967
Closes RHOAIENG-11118

Description

Opening the Select components when not attached to the appropriate scrolled container caused the scroll container to scroll to the top. Added a HOC to wrap around the select components to correctly determine the scroll container and append the popper for the select to.

How Has This Been Tested?

Tested manually. Ran RTL tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress This PR is in WIP state label Aug 28, 2024
Copy link
Contributor

openshift-ci bot commented Aug 28, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign manosnoam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 80.82%. Comparing base (4a0626e) to head (0586184).

Files with missing lines Patch % Lines
...onnectionTypes/fields/ConnectionTypeFormFields.tsx 33.33% 4 Missing ⚠️
...concepts/connectionTypes/ConnectionTypePreview.tsx 50.00% 1 Missing ⚠️
...cepts/connectionTypes/fields/DropdownFormField.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3134      +/-   ##
==========================================
- Coverage   80.84%   80.82%   -0.02%     
==========================================
  Files        1243     1243              
  Lines       27099    27106       +7     
  Branches     7144     7145       +1     
==========================================
+ Hits        21907    21909       +2     
- Misses       5192     5197       +5     
Files with missing lines Coverage Δ
...ts/connectionTypes/ConnectionTypePreviewDrawer.tsx 75.00% <ø> (ø)
...concepts/connectionTypes/ConnectionTypePreview.tsx 5.26% <50.00%> (ø)
...cepts/connectionTypes/fields/DropdownFormField.tsx 71.42% <50.00%> (-1.08%) ⬇️
...onnectionTypes/fields/ConnectionTypeFormFields.tsx 75.00% <33.33%> (-11.96%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a0626e...0586184. Read the comment docs.

@jeff-phillips-18 jeff-phillips-18 changed the title [WIP] Fix for scrolling on opening a select Fix for select components causing scroll container to jump Aug 29, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress This PR is in WIP state label Aug 29, 2024
@christianvogt christianvogt added the do-not-merge/hold This PR is hold for some reason label Aug 30, 2024
@jeff-phillips-18
Copy link
Contributor Author

Closing since the solution break tests. Hoping to get a PatternFly solution from patternfly/patternfly-react#10896

@jeff-phillips-18 jeff-phillips-18 deleted the fix-menu-jump branch November 12, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold This PR is hold for some reason
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants