-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-6573] Model Detail - Registered Deployments Section #3092
[RHOAIENG-6573] Model Detail - Registered Deployments Section #3092
Conversation
0556274
to
1a15306
Compare
1a15306
to
f7f8d3c
Compare
LGTM at a quick glance - will do a more complete review tomorrow morning. Thanks for the work @jpuzz0 . |
Thanks for the efforts @jpuzz0! One comment and two questions -
|
30c187e
to
63d8f6a
Compare
63d8f6a
to
4a90d81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-6573
Description
(cc @yih-wang)
How to test
Navigate to the version details of a given model version (archived or otherwise). Click on the registered deployments tab, verify the contents match the design in terms of the alert, table columns, and table data. If no table data exists, that means the version has no registered deployments, so you can create one using the toolbar action "Deploy".
Test Impact
Added unit tests and a cypress test verifying data can render in the registered deployments table.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main