feat(RegisterModel): 9914 autofill connection #3084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturley
reviewed
Aug 15, 2024
frontend/src/pages/modelRegistry/screens/RegisterModel/ConnectionModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisterModel/ConnectionModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisterModel/ConnectionModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisterModel/RegisterModel.scss
Outdated
Show resolved
Hide resolved
Signed-off-by: gitdallas <[email protected]> squash me Signed-off-by: gitdallas <[email protected]> squashme Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
Signed-off-by: gitdallas <[email protected]>
gitdallas
force-pushed
the
feat/9914-connection-autofill
branch
from
c2bd685 to
d0f27ec
Compare
mturley
approved these changes
Aug 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: https://issues.redhat.com/browse/RHOAIENG-9914
Description
On the register modal page, there will be a new button to the right of Model Location / Object Storage (when selected) that says "Autofill from data connection".
Clicking that should bring up a modal with a project selector and a data connection selector. Selecting a project will populate the data connection selector with it's available data connections that contain a bucket.
Selecting a data connection and hitting the submit button will populate the Object Storage region/endpoint/bucket in the register model form.
How Has This Been Tested?
Made sure that projects appear in project selector, and data connection is disabled with a note about selecting a project.
Upon selecting a project, data connection will either be populated or remain disabled with a note that the project does not contain any data connections.
Selected multiple data connections and made sure that the form populated with data from that data connection.
Test Impact
Added tests to the register model to check that the button appears when it should, the modal appears when the button is clicked, the correct labeling/content appears in the dropdowns, and the fields get populated correctly.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main