-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add deployment modal for model registry #3074
Add deployment modal for model registry #3074
Conversation
Thanks for the work @DaoDaoNoCode! Just a few comments -
|
@yih-wang Thanks for the review! I will update it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking really good! I have one actual change request (the comment in useLabeledDataConnections
) and then just some questions and suggestions.
frontend/src/pages/modelRegistry/screens/RegisteredModels/useLabeledDataConnections.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisteredModels/useRegisteredModelContext.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisteredModels/useRegisteredModelContext.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/RegisteredModels/useRegisteredModelContextForModal.ts
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelRegistry/screens/components/DeployRegisteredModelModal.tsx
Outdated
Show resolved
Hide resolved
...rc/pages/modelServing/screens/projects/InferenceServiceModal/ManageInferenceServiceModal.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx
Outdated
Show resolved
Hide resolved
f523086
to
6cb5161
Compare
frontend/src/pages/modelServing/screens/projects/kServeModal/ManageKServeModal.tsx
Outdated
Show resolved
Hide resolved
...d/src/pages/modelRegistry/screens/RegisteredModels/usePrefillDeployModalFromModelRegistry.ts
Show resolved
Hide resolved
Based on the comments above, I updated the following:
No items in the menu: Items in the menu:
@yih-wang Let me know what you think, thanks! |
@DaoDaoNoCode All the changes look good. Thanks for the rapid work! |
Thanks @yih-wang I made the requested change. |
6cb5161
to
d7101e2
Compare
LGTM, thanks @DaoDaoNoCode ! |
d7101e2
to
dfa2191
Compare
dfa2191
to
f052b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pulled and tested on the modelregistry-ui cluster - everything looks and works great here!! Thanks so much for the hard work @DaoDaoNoCode !
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JIRA: RHOAIENG-8396
Description
When you deploy a model based on a model registry, the following modal will show:
If anything wrong with the project, the corresponding error message will pop up:
Otherwise, the current KServe modal or InferenceService modal will pop up depending on the project's serving platform. The name will be pre-filled as
{modelName} - {versionName}
:There is a helper text if the model registry version contains a prompt model format:
The data connections part will be decided by the model artifact URI.
If there are more than 1 matches, we don't pre-select the data connection:
If there is only one match, we pre-select the recommended data connection:
If there is no match, we pre-select the new data connection field:
The path will always be pre-filled based on the URI parsing result:
How Has This Been Tested?
Deploy
on the version actionNew data connection
andpath
field is pre-filledbucket
,endpoint
andregion
as the model registry version artifact URI you are going to deploy with)Existing data connection
and the only matching data connection is labeled and pre-selectedExisting data connection
and both data connections in the dropdown menu are labeled as recommended, but neither is pre-selectedTest Impact
Add a unit test to test the util function that shows the error message when choosing the project.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main