[RHOAIENG-8816] Automatic discovery of Accelerator profile handles AMD GPUs like they were NVIDIA

[jpuzz0]

https://issues.redhat.com/browse/RHOAIENG-8816

Description

Only create accelerator when nvidia type nodes are detected from the server's list of nodes.

How Has This Been Tested?

Manually tested. This doesn't seem to be re-creatable in dev without some hard-coded intervention. The condition to create the accelerator has been adjusted to make sure nvidia nodes exist, however I was not able to simulate the "configured" state being true, which is the other part of the condition.

Test steps

Testing this is not straight forward and requires deleting resources in the openshift console and restarting the backend afterwards + manually editing the condition to bypass the "configured" state. I believe this change is one we can have the reporter of the issue test once released to be sure this resolves his issue.

1. Update

   odh-dashboard/backend/src/utils/resourceUtils.ts

   Line 684 in 3f02696

   if (acceleratorDetected.configured && hasNvidiaNodes) {

   locally and remove the acceleratorDetected.configured portion of the condition.
2. Stop your locally running dev "backend"
3. Delete console resources:

5. Start your local dev "backend" and see the accelerator profile created. If no Nvidia nodes exist, then no accelerator should be created.

Request review criteria:

Self checklist (all need to be checked):

• The developer has manually tested the changes and verified that the changes work
• Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

• Included any necessary screenshots or gifs if it was a UI change.
• Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

• The developer has tested their solution on a cluster by using the image produced by the PR to main

[pnaik1]

@jpuzz0, I was trying to test your pr locally, followed your Test steps, after restarting my backend, I see
migration-gpu-status config automatically created in the openshift console, That means I have nvidia node??
If so how can I test for no nvidia node??

[jpuzz0]

@jpuzz0, I was trying to test your pr locally, followed your Test steps, after restarting my backend, I see migration-gpu-status config automatically created in the openshift console, That means I have nvidia node?? If so how can I test for no nvidia node??

@pnaik1
No, migration-gpu-status will be automatically created in the console regardless. If you want to create different node types I suggest reaching out to #forum-openshift-ai-dashboard.

[Gkrumbach07]

perfect thank you

/lgtm

[Gkrumbach07]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Gkrumbach07]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment