Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-7791:Add test configuration template file for cypress tests #3004

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

sthundat
Copy link
Contributor

Closes: RHOAIENG-7791

Description

This is the template file which holds the structure of the configuration file and the default values for test.
The values are being generated dynamically during runtime and populate fields of template file data and generates the final content for the actual configuration file.

How Has This Been Tested?

Need to run the jenkins pipeline job for cypress tests

@openshift-ci openshift-ci bot requested review from alexcreasy and mturley July 15, 2024 16:24
@openshift-ci openshift-ci bot added the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Jul 15, 2024
Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

Hi @sthundat. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sthundat
Copy link
Contributor Author

@christianvogt review please

@christianvogt christianvogt added the ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests. label Jul 15, 2024
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christianvogt christianvogt removed the needs-ok-to-test The openshift bot needs to label PRs from non members to avoid strain on the CI label Jul 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 48b04aa into opendatahub-io:main Jul 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm ok-to-test The openshift bot needs `ok-to-test` to allow non member PRs to run the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants