Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart the pods after updating configMap in workbench #3002

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

ppadti
Copy link
Contributor

@ppadti ppadti commented Jul 15, 2024

Closes: RHOAIENG-1210

Description

This PR will add notebooks.opendatahub.io/notebook-restart=true to notebook CR to restart the pod after updating config map.

How Has This Been Tested?

  1. Create a workbench with adding the Environment variables (ConfigMap Environment variables type).
  2. after creation, update the config map. You can see that the pods will restart.

Test Impact

NA, added an annotation.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and mturley July 15, 2024 12:02
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, but i seem to be having trouble getting a workbench running. any ideas? i haven't done it before, and when i try, the status seems stuck at "starting", "Waiting for server request to start..."

@emilys314
Copy link
Contributor

I was able to confirm that the workbench will restart when you update config maps environment variables

@jpuzz0
Copy link
Contributor

jpuzz0 commented Jul 22, 2024

I also checked this out and inspecting a particular pod's details belonging to the workbench I have, it appears the status of that pod updates before resuming "Running" again afterwards. I assumed this is how we'd verify the pods are restarted, but if not, I would like to know how this is meant to be done.

Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this locally. I was able to see the pod restarting by finding it in the OCP console and seeing it get recreated there.

Copy link
Contributor

openshift-ci bot commented Jul 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gitdallas, mturley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 82345b0 into opendatahub-io:main Jul 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants