-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restart the pods after updating configMap in workbench #3002
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good to me, but i seem to be having trouble getting a workbench running. any ideas? i haven't done it before, and when i try, the status seems stuck at "starting", "Waiting for server request to start..."
I was able to confirm that the workbench will restart when you update config maps environment variables |
I also checked this out and inspecting a particular pod's details belonging to the workbench I have, it appears the status of that pod updates before resuming "Running" again afterwards. I assumed this is how we'd verify the pods are restarted, but if not, I would like to know how this is meant to be done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified this locally. I was able to see the pod restarting by finding it in the OCP console and seeing it get recreated there.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gitdallas, mturley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-1210
Description
This PR will add
notebooks.opendatahub.io/notebook-restart=true
to notebook CR to restart the pod after updating config map.How Has This Been Tested?
Test Impact
NA, added an annotation.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main