Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no metrics state for compare runs metrics section #2993

Merged

Conversation

DaoDaoNoCode
Copy link
Member

@DaoDaoNoCode DaoDaoNoCode commented Jul 10, 2024

JIRA: RHOAIENG-8406

Description

Add an empty state when there are runs selected but no metrics to compare for all the tabs in compare run metrics section.

Screenshot 2024-07-10 at 4 53 04 PM

How Has This Been Tested?

  1. Create some runs with a pipeline that will not generate metrics
  2. Go to compare runs page
  3. See the metrics section, check and uncheck the runs
  4. Make sure the empty state is shown as described

Test Impact

Added some cypress tests to verify the empty state

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@DaoDaoNoCode DaoDaoNoCode requested a review from Gkrumbach07 July 10, 2024 20:58
@openshift-ci openshift-ci bot requested review from mturley and ppadti July 10, 2024 20:59
@pnaik1
Copy link
Contributor

pnaik1 commented Jul 12, 2024

Tested locally
/lgtm
Runs are selected but no metrics is present to compare

Screenshot 2024-07-12 at 1 48 29 PM

Runs are unchecked

Screenshot 2024-07-12 at 1 48 38 PM

@Gkrumbach07
Copy link
Member

Screenshot 2024-07-12 at 1 55 08 PM looks good

/approve

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ee4410c into opendatahub-io:main Jul 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants