Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-9230 Restructure InitSegment #2989

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

pilhuhn
Copy link
Contributor

@pilhuhn pilhuhn commented Jul 10, 2024

Restructure InitSegment
https://issues.redhat.com/browse/RHOAIENG-9230

Description

Split off Segment initialisation from usage.
Remove username from init code and only use when needed to fire an identify event.
No user-visible changes.

How Has This Been Tested?

Manual test by looking at browser console

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

cc @andrewballantyne

@openshift-ci openshift-ci bot added the lgtm label Jul 12, 2024
Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 27ca9e8 into opendatahub-io:main Jul 12, 2024
6 checks passed
@pilhuhn pilhuhn deleted the RHOAIENG-9230 branch October 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants