Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cluster-admins to administration tab #2988

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jul 9, 2024

Closes: RHOAIENG-7659

Description

Users in the group cluster-admins but not in odh-admins showed up as users in the administration tab. I added this group so that they would instead show as admin

This fix will also show cluster-admin users with no previous activity in the tab.

How Has This Been Tested?

  1. Comment out the one-liner
  2. Add a cluster-admin to your cluster, but do not add them to the odh-admins group.
  3. Create a notebook server (Applications -> Enabled -> Jupyter -> Notebooks Server) logged in with the credentials of the NEW USER you just created.
  4. Go to Applications -> Enabled -> Jupyter -> Administration. They should show up as a user since it just had recent activity.
  5. Repeat step 2.
  6. Uncomment the one-line fix
  7. After reloading, you will be able to see that the users in steps 1 and 5 show up as 'admins', even though 5 had no previous activity.

Test Impact

N/A... Small fix, and code changes are unlikely to break this functionality since it is a one-liner.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from christianvogt and mturley July 9, 2024 20:36
@christianvogt
Copy link
Contributor

/lgtm
/approve

Tested on Robert's cluster logged in as cubeadmin3.
All users referenced by the cluster-admin group now show up regardless of having last activity or not. Furthermore they show up as an Admin

Before:
image

After:
image

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8a4261f into opendatahub-io:main Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants