-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update depricated PF multiselect component #2975
Update depricated PF multiselect component #2975
Conversation
|
This is a PF issue. Though it works on the documentation page, if you try the code sandbox it does not and the toggle button is in the tab order for focus. |
0d5475c
to
bb99222
Compare
/lgtm cancel |
d7ca5ed
to
ce12204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm cancel |
ba55a53
to
0d16a4f
Compare
0d16a4f
to
413e886
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-421
Description
This PR updates the deprecated Patternfly 4 select component with the PF5 multi select component
How Has This Been Tested?
This is tested with
npm run test
as well as on localhost, and using the Cypress tests inuserManagement.cy.ts
Test Impact
No new tests were added as there are no functionality changes
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main