Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pipeline execution tests #2968

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

rsun19
Copy link
Contributor

@rsun19 rsun19 commented Jun 28, 2024

Closes: RHOAIENG-6986

Description

I added pipeline executions tests (focused on table and details) to improve code coverage

How Has This Been Tested?

npm run test

Test Impact

I added tests and mocks.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@rsun19 rsun19 force-pushed the pipeline-executions branch from 7266d58 to f73b183 Compare June 28, 2024 16:47
Copy link
Contributor

@christianvogt christianvogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i forgot to submit my review yesterday so there's likely overlap with what Purva mentioned.

@ConorOM1
Copy link
Contributor

ConorOM1 commented Jul 4, 2024

should some testing be included for Pipeline Server Actions aswell ?

@rsun19
Copy link
Contributor Author

rsun19 commented Jul 5, 2024

should some testing be included for Pipeline Server Actions aswell ?

Not sure if this is necessary. Tagging @christianvogt

@rsun19 rsun19 force-pushed the pipeline-executions branch 4 times, most recently from f88e7ac to ae03e93 Compare July 5, 2024 15:00
@rsun19 rsun19 force-pushed the pipeline-executions branch from ae03e93 to bbf5e5a Compare July 5, 2024 20:58
@rsun19 rsun19 force-pushed the pipeline-executions branch from bbf5e5a to 521817b Compare July 8, 2024 20:43
@christianvogt
Copy link
Contributor

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 3b48d99 into opendatahub-io:main Jul 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants