-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pipeline execution tests #2968
added pipeline execution tests #2968
Conversation
7266d58
to
f73b183
Compare
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry i forgot to submit my review yesterday so there's likely overlap with what Purva mentioned.
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Outdated
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/pages/pipelines/executions.ts
Outdated
Show resolved
Hide resolved
should some testing be included for |
Not sure if this is necessary. Tagging @christianvogt |
f88e7ac
to
ae03e93
Compare
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Show resolved
Hide resolved
frontend/src/__tests__/cypress/cypress/tests/mocked/pipelines/executions.cy.ts
Show resolved
Hide resolved
ae03e93
to
bbf5e5a
Compare
bbf5e5a
to
521817b
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-6986
Description
I added pipeline executions tests (focused on table and details) to improve code coverage
How Has This Been Tested?
npm run test
Test Impact
I added tests and mocks.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main