-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-7942]: Update Side Panel Behavior to Pan Graph on Node Selection #2943
[RHOAIENG-7942]: Update Side Panel Behavior to Pan Graph on Node Selection #2943
Conversation
frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx
Show resolved
Hide resolved
frontend/src/concepts/pipelines/content/pipelinesDetails/pipeline/PipelineDetails.tsx
Show resolved
Hide resolved
frontend/src/concepts/topology/PipelineVisualizationSurface.tsx
Outdated
Show resolved
Hide resolved
e36aec4
to
ef67597
Compare
@jenny-s51 It looks like the topology action buttons are pushed under the screen |
This was the reason for:
and the flex components in https://github.com/opendatahub-io/odh-dashboard/pull/2943/files#diff-153248b4472ef25aa4c01cf4f312bdddef50f7fe6052090df18ddd810437af90 |
64f9308
to
9758f52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR feedback @jeff-phillips-18 . Reverted to apply the styles and Flex components
@jenny-s51 The drawer can be too small now and some tabs get hidden |
a65e3a2
to
54e8027
Compare
@Gkrumbach07 while looking into the issue you found, I noticed a bug with the drawer component that was causing the drawer panel to remain in the view when the drawer was closed. @jeff-phillips-18 helped come up with a good solution to this, updated the PR with the fix. @Gkrumbach07 still seeing the issue with the hidden tabs though on initial resize. Investigating... this may be an issue on the PF side |
Looks to be a PF issue. The Tabs component only determines if the scrolling components are needed when the window resizes. If the user resizes the side panel, the Tabs will not realize that the scroll components have become necessary. |
frontend/src/concepts/topology/PipelineVisualizationSurface.scss
Outdated
Show resolved
Hide resolved
6a74c59
to
2b51cbd
Compare
Investigating test errors in pipelinesTopology with the latest rebase/updates (after these files were recently refactored on |
f0cc1be
to
0e4ddec
Compare
…ction Fix side panel sizing, scrolling, and contents (#8) apply light variants to page section, fix linting issue Gage PR feedback fix tests add flexItems and minWidth Fix to hide side panel completely on close update minWidth, fix pipelineRunDetails fix pipeline details view update PipelineRunDetailsTabs try fixing test error
Updated/rebased with latest changes from @jeff-phillips-18 @Gkrumbach07 if you have a moment to take another look would be much appreciated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://issues.redhat.com/browse/RHOAIENG-7942
Description
Previously if we selected a pipelines node and the side panel opened, the node that toggled the panel was obscured by the panel.
Now when a node is selected, the node that toggled the drawer is panned into view.
Screen.Recording.2024-06-21.at.2.45.49.PM.mov
How Has This Been Tested?
Test Impact
N/A
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main