-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RHOAIENG-8359] Move and update pipeline and run detail tabs #2911
[RHOAIENG-8359] Move and update pipeline and run detail tabs #2911
Conversation
41d4263
to
1b75630
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2911 +/- ##
==========================================
- Coverage 78.38% 78.38% -0.01%
==========================================
Files 1128 1127 -1
Lines 24023 23988 -35
Branches 6076 6066 -10
==========================================
- Hits 18831 18803 -28
+ Misses 5192 5185 -7
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Some images where added? |
style={{ flex: 1 }} | ||
> | ||
<TabContentBody className="pf-v5-u-h-100" hasPadding> | ||
<PipelineDetailsYAML filename={run?.display_name} content={run ? { run } : null} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Yan wants this to be the version pipeline spec and then we just dont show the pipeline run result yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"just dont show the pipeline run result yaml" I assume this means hide the tab when the run's version's pipeline spec is not found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah we are replacing the run details with the pipeline spec. so it will hide the tab if we cant find the version for some reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done in my last commit.
bd92c6f
to
2b9e780
Compare
I'm not sure what you're asking. |
...tion -- should show allow project creation from the empty state when privileged (failed).png
Outdated
Show resolved
Hide resolved
2b9e780
to
b02281c
Compare
matches mocks /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Closes: RHOAIENG-8359
Description
Pipeline run details
Pipeline version details
(@yannnz)
How Has This Been Tested?
Manual tests & cypress tests
Test Impact
Needed to update pipeline run details cypress tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main