Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-8359] Move and update pipeline and run detail tabs #2911

Merged

Conversation

jpuzz0
Copy link
Contributor

@jpuzz0 jpuzz0 commented Jun 13, 2024

Closes: RHOAIENG-8359

Description

  • Added "Summary" tab to the pipelines details page
  • Moved content from pipeline run details bottom drawer tabs at the top of the application page
  • Updated pipeline run details content based on mockups

Pipeline run details
image
image
image

Pipeline version details
image
image
image
(@yannnz)

How Has This Been Tested?

Manual tests & cypress tests

Test Impact

Needed to update pipeline run details cypress tests

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from dpanshug and ppadti June 13, 2024 16:27
@openshift-merge-robot openshift-merge-robot added the needs-rebase PR needs to be rebased label Jun 13, 2024
@jpuzz0 jpuzz0 force-pushed the RHOAIENG-8359-move-run-details branch from 41d4263 to 1b75630 Compare June 13, 2024 16:40
@openshift-merge-robot openshift-merge-robot removed the needs-rebase PR needs to be rebased label Jun 13, 2024
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 88.09524% with 10 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (9484646) to head (b02281c).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
- Coverage   78.38%   78.38%   -0.01%     
==========================================
  Files        1128     1127       -1     
  Lines       24023    23988      -35     
  Branches     6076     6066      -10     
==========================================
- Hits        18831    18803      -28     
+ Misses       5192     5185       -7     
Files Coverage Δ
...tent/pipelinesDetails/pipeline/PipelineDetails.tsx 88.33% <100.00%> (+0.19%) ⬆️
...inesDetails/pipelineRun/PipelineRunDetailsTabs.tsx 100.00% <100.00%> (ø)
...linesDetails/pipelineRun/PipelineRunTabDetails.tsx 94.73% <100.00%> (+4.26%) ⬆️
...rontend/src/concepts/topology/PipelineTopology.tsx 94.73% <50.00%> (-5.27%) ⬇️
...esDetails/pipelineRunJob/PipelineRunJobDetails.tsx 85.71% <88.23%> (ø)
...etails/pipeline/PipelineSummaryDescriptionList.tsx 78.57% <78.57%> (ø)
...ipelinesDetails/pipelineRun/PipelineRunDetails.tsx 80.35% <77.77%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9484646...b02281c. Read the comment docs.

@jpuzz0 jpuzz0 requested a review from yannnz June 13, 2024 17:30
@Gkrumbach07
Copy link
Member

Some images where added?

style={{ flex: 1 }}
>
<TabContentBody className="pf-v5-u-h-100" hasPadding>
<PipelineDetailsYAML filename={run?.display_name} content={run ? { run } : null} />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Yan wants this to be the version pipeline spec and then we just dont show the pipeline run result yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"just dont show the pipeline run result yaml" I assume this means hide the tab when the run's version's pipeline spec is not found?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah we are replacing the run details with the pipeline spec. so it will hide the tab if we cant find the version for some reason

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done in my last commit.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-8359-move-run-details branch from bd92c6f to 2b9e780 Compare June 13, 2024 20:02
@jpuzz0
Copy link
Contributor Author

jpuzz0 commented Jun 13, 2024

Some images where added?

I'm not sure what you're asking.

@jpuzz0 jpuzz0 force-pushed the RHOAIENG-8359-move-run-details branch from 2b9e780 to b02281c Compare June 14, 2024 03:01
@Gkrumbach07
Copy link
Member

matches mocks

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gkrumbach07

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 78e21a0 into opendatahub-io:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants