Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-7946]: Hide Status Icon on Hovered Artifact Nodes #2905

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

jenny-s51
Copy link
Contributor

@jenny-s51 jenny-s51 commented Jun 12, 2024

JIRA: https://issues.redhat.com/browse/RHOAIENG-7946

Description

Hides status icon on hovered artifact nodes as per UX feedback of artifact node rendering.

Before - default artifact node:
Screenshot 2024-06-12 at 2 26 41 PM
Before - hovered artifact node:
Screenshot 2024-06-12 at 2 26 46 PM

After - default artifact node:
Screenshot 2024-06-12 at 2 28 12 PM
After - hovered artifact node:
Screenshot 2024-06-12 at 2 22 53 PM

How Has This Been Tested?

  1. Navigate to a pipeline run with artifacts (e.g. iris pipeline)
  2. Verify the artifact nodes render the artifact icon beside the text when hovered

Test Impact

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from manaswinidas and pnaik1 June 12, 2024 19:04
@jenny-s51 jenny-s51 requested review from Gkrumbach07, dpanshug and DaoDaoNoCode and removed request for manaswinidas and pnaik1 June 12, 2024 19:08
Copy link
Contributor

@jpuzz0 jpuzz0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approved

Copy link
Contributor

openshift-ci bot commented Jun 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jpuzz0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.47%. Comparing base (e1210fb) to head (cd3aabb).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2905      +/-   ##
==========================================
- Coverage   78.47%   78.47%   -0.01%     
==========================================
  Files        1127     1127              
  Lines       23949    23958       +9     
  Branches     6037     6044       +7     
==========================================
+ Hits        18794    18800       +6     
- Misses       5155     5158       +3     
Files Coverage Δ
...concepts/topology/customNodes/ArtifactTaskNode.tsx 72.00% <40.00%> (-3.56%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1210fb...cd3aabb. Read the comment docs.

@openshift-merge-bot openshift-merge-bot bot merged commit f17df69 into opendatahub-io:main Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants