-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHOAIENG-5150: Initial elastic odh application addition #2900
RHOAIENG-5150: Initial elastic odh application addition #2900
Conversation
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
==========================================
- Coverage 78.64% 78.46% -0.19%
==========================================
Files 1120 1127 +7
Lines 23757 23953 +196
Branches 5979 6039 +60
==========================================
+ Hits 18683 18794 +111
- Misses 5074 5159 +85 see 35 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This is also being reviewed by PM and CCS - please hold on merging until we have their approval. |
support: third party support | ||
quickStart: '' | ||
getStartedLink: https://www.elastic.co/guide/en/esre/current/index.html | ||
csvName: elasticsearch-eck-operator-certified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgutride Just a question here, the logic we have in place is using startsWith
, just in case we have multiple csv that have the same prefix. I don't know wether we wanna add support from the Openshift ECK operator elasticsearch-operator
too, in that case we might wanna change the csvName
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name is on this line in their repo: https://github.com/elastic/cloud-on-k8s/blob/8270ad0ae9aebbc39a31fede2c2eb90def222d5b/hack/operatorhub/config.yaml#L42
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lucferbux The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds new manifest for elastic search - vector db solution based on collaboration with them.
Closes: https://issues.redhat.com/browse/RHOAIENG-5150
How Has This Been Tested?
Test Impact
Applied yaml to running cluster (nightly odh)
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
27-8b9d-200427768137)
After the PR is posted & before it merges:
main