Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHOAIENG-5150: Initial elastic odh application addition #2900

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

dgutride
Copy link
Contributor

@dgutride dgutride commented Jun 11, 2024

Description

Adds new manifest for elastic search - vector db solution based on collaboration with them.
Closes: https://issues.redhat.com/browse/RHOAIENG-5150

How Has This Been Tested?

Test Impact

Applied yaml to running cluster (nightly odh)

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.

Screenshot 2024-06-11 at 9 49 30 AM
Screenshot 2024-06-11 at 9 50 09 AM
27-8b9d-200427768137)
Screenshot 2024-06-11 at 9 49 39 AM

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from lucferbux and pnaik1 June 11, 2024 13:56
@manaswinidas
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jun 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.46%. Comparing base (b4db549) to head (5ef81e0).
Report is 42 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2900      +/-   ##
==========================================
- Coverage   78.64%   78.46%   -0.19%     
==========================================
  Files        1120     1127       +7     
  Lines       23757    23953     +196     
  Branches     5979     6039      +60     
==========================================
+ Hits        18683    18794     +111     
- Misses       5074     5159      +85     

see 35 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4db549...5ef81e0. Read the comment docs.

@dgutride
Copy link
Contributor Author

This is also being reviewed by PM and CCS - please hold on merging until we have their approval.

@openshift-ci openshift-ci bot removed the lgtm label Jun 12, 2024
support: third party support
quickStart: ''
getStartedLink: https://www.elastic.co/guide/en/esre/current/index.html
csvName: elasticsearch-eck-operator-certified
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgutride Just a question here, the logic we have in place is using startsWith, just in case we have multiple csv that have the same prefix. I don't know wether we wanna add support from the Openshift ECK operator elasticsearch-operator too, in that case we might wanna change the csvName

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@lucferbux lucferbux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tested in cluster, added the operator and it appears in the enabled page.
Screenshot 2024-06-14 at 12 43 12
Screenshot 2024-06-14 at 12 38 09

@openshift-ci openshift-ci bot added the lgtm label Jun 14, 2024
Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lucferbux

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f5fa031 into opendatahub-io:main Jun 14, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants