Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gRPC-web dev tools in dev mode for MLMD client #2895

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

mturley
Copy link
Contributor

@mturley mturley commented Jun 10, 2024

Supports RHOAIENG-7338 and RHOAIENG-7335, but opening this PR separately since it may be generally useful for ongoing dev on other stories as well

Description

In dev mode, enables support for the gRPC-Web Developer Tools browser extension (Chrome install link) (Firefox install link) when initializing the gRPC client for MLMD in PipelinesContext.

This dev tool allows us to view gRPC responses in deserialized JSON instead of base64 encoded binary format. This should make it easier to capture example data for mocks for Cypress tests.

The initialization code comes from the Usage section of the extension's GitHub readme.

How Has This Been Tested?

  • Tested that it has no effect when not running in dev mode.
  • Tested that it has no effect when the browser extension is not installed.
  • Tested that our client's requests are appearing in the extension's log when it is installed.

Test Impact

N/A

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

@openshift-ci openshift-ci bot requested review from alexcreasy and dpanshug June 10, 2024 22:12
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (b4db549) to head (bc2aa62).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   78.64%   78.63%   -0.01%     
==========================================
  Files        1120     1120              
  Lines       23757    23761       +4     
  Branches     5979     5981       +2     
==========================================
+ Hits        18683    18684       +1     
- Misses       5074     5077       +3     
Files Coverage Δ
...rc/concepts/pipelines/context/PipelinesContext.tsx 84.44% <66.66%> (-1.61%) ⬇️

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4db549...bc2aa62. Read the comment docs.

@mturley mturley requested a review from christianvogt June 11, 2024 14:00
Copy link
Contributor

@gitdallas gitdallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

image

@christianvogt
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Jun 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, gitdallas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit efd0faf into opendatahub-io:main Jun 11, 2024
8 checks passed
@mturley mturley deleted the grpc-devtools branch June 11, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants