-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable pipeline experiments in dashboard config #2892
Enable pipeline experiments in dashboard config #2892
Conversation
c65a910
to
b6502bd
Compare
edbab67
to
0793a44
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2892 +/- ##
==========================================
- Coverage 78.46% 78.33% -0.13%
==========================================
Files 1127 1128 +1
Lines 23943 24034 +91
Branches 6033 6076 +43
==========================================
+ Hits 18786 18827 +41
- Misses 5157 5207 +50
... and 18 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Andrew said to keep it around. as long as we cant get to it from supported flows @DaoDaoNoCode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DaoDaoNoCode I updated the PR |
@Gkrumbach07 Can you rebase the PR? |
0793a44
to
486ad5a
Compare
486ad5a
to
81480e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The link here on execution details page needs to be updated, otherwise it will navigate to old global pipeline run details page.
81480e2
to
9e3a6fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all the routes I could think of, it works well.
/lgtm
chore: Update URLs for cloning pipeline runs and viewing pipeline runs and schedules create run and job auto add now Refactor PipelineTaskDetails component to remove unused code and improve readability chore: Update route for pipeline run details namespace on execution details page chore: Update route for pipeline run details namespace on execution details page chore: Update route for pipeline run details namespace on execution details page
9e3a6fd
to
7d528ef
Compare
@DaoDaoNoCode I ended up finding a clean solution for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
merging this /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: DaoDaoNoCode, dpanshug, Gkrumbach07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
closes: https://issues.redhat.com/browse/RHOAIENG-3826
Description
/pipelines
and not/pipelineRuns
How Has This Been Tested?
/pipelineRuns
Test Impact
will need to updated routes tests
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main